Skip to content

Commit 40242bd

Browse files
authored
[ISSUE-2032] Fix New Loadout with Link Identifier (#2038)
1 parent b8f3152 commit 40242bd

3 files changed

Lines changed: 27 additions & 1 deletion

File tree

spec/System/TestLoadouts_spec.lua

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,22 @@ describe("TestLoadouts", function()
3333
assert.are.equals(2, build.configTab.activeConfigSetId)
3434
assert.is_true(build.modFlag)
3535
end)
36+
37+
it("Creates a new loadout with the correct name and sets it as active when the name has a link identifier",
38+
function()
39+
local loadoutName = "Loadout Name {1}"
40+
build:NewLoadout(loadoutName)
41+
build:SyncLoadouts()
42+
assert.are.equals(1, #build.loadoutsList) -- Link identifiers are not yet supported in the loadoutsList
43+
-- assert.are.equals(loadoutName, build.loadoutsList[2].title)
44+
assert.are.equals(7, #build.controls.buildLoadouts.list)
45+
assert.are.equals(loadoutName, build.controls.buildLoadouts.list[3])
46+
assert.are.equals(2, build.treeTab.activeSpec)
47+
assert.are.equals(2, build.itemsTab.activeItemSetId)
48+
assert.are.equals(2, build.skillsTab.activeSkillSetId)
49+
assert.are.equals(2, build.configTab.activeConfigSetId)
50+
assert.is_true(build.modFlag)
51+
end)
3652
end)
3753

3854
describe("CopyLoadout", function()
@@ -660,6 +676,16 @@ describe("TestLoadouts", function()
660676
assert.are.equals(loadoutName, build.loadoutsList[2].title)
661677
assert.is_true(build.modFlag)
662678
end)
679+
680+
it("creates a new loadout with a linkIdentifier", function()
681+
local loadoutName = "Loadout Name {1}"
682+
buildSetService:NewLoadout(loadoutName)
683+
assert.are.equals(1, #build.loadoutsList) -- link identifiers are not yet supported in the loadoutsList
684+
-- assert.are.equals(loadoutName, build.loadoutsList[2].title)
685+
assert.are.equals(7, #build.controls.buildLoadouts.list)
686+
assert.are.equals(loadoutName, build.controls.buildLoadouts.list[3])
687+
assert.is_true(build.modFlag)
688+
end)
663689
end)
664690

665691
describe("CopyLoadout", function()

src/Classes/BuildSetService.lua

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ end)
99

1010
function BuildSetServiceClass:NewLoadout(name)
1111
self.buildMode:NewLoadout(name)
12-
self.buildMode:SyncLoadouts()
1312
end
1413

1514
function BuildSetServiceClass:CopyLoadout(copyLoadoutName, newName)

src/Modules/Build.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,6 +760,7 @@ function buildMode:NewLoadout(loadoutName)
760760

761761
newSpec.title = loadoutName
762762
t_insert(self.treeTab.specList, newSpec)
763+
self:SyncLoadouts() -- Sync loadouts to update the dropdown with the new loadout and select it
763764
self:SetActiveLoadout(self:GetLoadoutByName(loadoutName))
764765

765766
self.modFlag = true

0 commit comments

Comments
 (0)