Remove hard coding for socket bound runes

Author: vaisest

src/Classes/ItemsTab.lua

@@ -1684,25 +1684,6 @@ local function isAugmentable(item)
 	return (item.sockets and #item.sockets > 0) or (item.base.socketLimit and item.base.socketLimit > 0)
 end
 
--- a list of augments which cannot be removed from items. this data does not seem to be available in
--- the rune data.
-local socketBoundAugments = {
-	["Raven-Touched Shard"] = true,
-	["Passion of Aldur"] = true,
-	["Breath of Aldur"] = true,
-	["Ire of Aldur"] = true,
-	["Betrayal of Aldur"] = true,
-	["Serle's Triumph"] = true,
-	["Cadigan's Epiphany"] = true,
-	["Uhtred's Sidereus"] = true,
-	["Kolr's Hunt"] = true,
-	["Vorana's Carnage"] = true,
-	["Thrud's Might"] = true,
-	["Medved's Tending"] = true,
-	["Katla's Gloom"] = true,
-	["Legacy of Ironbound"] = true,
-}
-
 function ItemsTabClass:CopyAnointsAndAugments(newItem, copyAugments, overwrite, sourceSlotName)
 	local isWeapon = newItem.base.tags and (newItem.base.tags.onehand or newItem.base.tags.twohand)
 	local isShield = newItem.base.tags and (newItem.base.tags.shield or newItem.base.tags.focus)
@@ -1758,13 +1739,15 @@ function ItemsTabClass:CopyAnointsAndAugments(newItem, copyAugments, overwrite,
 			local skipped = 0
 			if shouldChangeAugments then
 				for i = 1, #newItem.sockets do
-					-- avoid overwriting socket bound runes as removing these from trade results
-					-- will be confusing
-					if overwrite and newItem.runes[i] and socketBoundAugments[newItem.runes[i]] then
-						-- if the new item has more slots than the old item, we still copy old
-						-- runes in order after skipping the socket bound rune
-						skipped = skipped + 1
-						goto continue
+					for _, rune in ipairs(validRunes) do
+						-- avoid overwriting socket bound runes as removing these from e.g. trade results
+						-- will be confusing
+						if rune.name == newItem.runes[i] and rune.isSocketBound then
+							-- if the new item has more slots than the old item, we still copy old
+							-- runes in order after skipping the socket bound rune
+							skipped = skipped + 1
+							goto continue
+						end
 					end
 					newItem.runes[i] = "None"
 					if currentRunes[i - skipped] then
@@ -1928,11 +1911,11 @@ function ItemsTabClass:UpdateAffixControls()
 	self:UpdateCustomControls()
 end
 
-local runeModLines = { { name = "None", label = "None", lines = { "None" }, order = -1, slot = "None", group = -1 } }
+local runeModLines = { { name = "None", label = "None", lines = { "None" }, order = -1, slot = "None", group = -1, isSocketBound = false } }
 for name, runeMods in pairs(data.itemMods.Runes) do
 	-- Some runes have multiple mod lines; insert each as separate entry
 	for slotType, runeMod in pairs(runeMods) do
-		t_insert(runeModLines, { name = name, label = runeMod[1], lines = runeMod, req = runeMod.rank[1], order = runeMod.statOrder[1], slot = slotType, type = runeMod.type, group = #runeMod })
+		t_insert(runeModLines, { name = name, label = runeMod[1], lines = runeMod, req = runeMod.rank[1], order = runeMod.statOrder[1], slot = slotType, type = runeMod.type, group = #runeMod, isSocketBound = runeMod.isSocketBound })
 	end
 end
 table.sort(runeModLines, function(a, b)