Skip to content

Commit 594fa4b

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Shrine sceptre Auras not making linked buffs have no Spirit cost (#2077)
The purity auras granted by the Shrine sceptre bases all have a reservation multiplier of -100 so the buffs linked to them have no spirit cost Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 62eceb8 commit 594fa4b

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

spec/System/TestSkills_spec.lua

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,13 @@ describe("TestSkills", function()
9494
assert.True(build.calcsTab.mainOutput.SpiritReservedPercent > oneCurseReservation)
9595
end)
9696

97+
it("applies active skill reservation multiplier to linked buff spirit reservation", function()
98+
build.skillsTab:PasteSocketGroup("Purity of Fire 20/0 1\nVitality II 1/0 1\n")
99+
runCallback("OnFrame")
100+
101+
assert.are.equals(0, build.calcsTab.mainOutput.SpiritReserved)
102+
end)
103+
97104
it("Keeps Virtuous armour scaling during Full DPS loop", function()
98105
build.itemsTab:CreateDisplayItemFromRaw("New Item\nRazor Quarterstaff\nQuality: 0")
99106
build.itemsTab:AddDisplayItem()

src/Modules/CalcActiveSkill.lua

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -751,6 +751,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)
751751

752752
-- Add extra modifiers from granted effect level
753753
local level = activeEffect.grantedEffectLevel
754+
if level.reservationMultiplier then
755+
skillModList:NewMod("ReservationMultiplier", "MORE", level.reservationMultiplier, activeGrantedEffect.modSource)
756+
end
754757
activeSkill.skillData.CritChance = level.critChance
755758
if level.damageMultiplier then
756759
skillModList:NewMod("Damage", "MORE", level.damageMultiplier, activeEffect.grantedEffect.modSource, ModFlag.Attack)

0 commit comments

Comments
 (0)