Fix buy similar popup not updating url and persist selections (#2339)

* Fix edit controls not updating buy similar url

* Fix league/realm selectors not rebuilding url and make them persistent

* Add basic tests for findTradeIdOption

* Fix crash on missing socket in viewer

* Fix changing dropdowns not updating trade URL

Changing the dropdowns wasn't auto updating the trade URL

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

Author: vaisest

spec/System/TestCompareBuySimilar_spec.lua

@@ -86,4 +86,73 @@ Implicits: 1
 			assert.equal(50, entries[2].value)
 		end)
 	end)
+
+	describe("popup URL controls", function()
+		local originalCopy
+		local originalOpenURL
+		local originalFetchLeagues
+		local copiedUrl
+		local searchEnv
+
+		before_each(function()
+			newBuild()
+			local requests = build.itemsTab.tradeQuery.tradeQueryRequests
+			originalFetchLeagues = requests.FetchLeagues
+			requests.FetchLeagues = function(_, realm, callback)
+				callback({ "Test League", "Standard" })
+			end
+		end)
+
+		after_each(function()
+			build.itemsTab.tradeQuery.tradeQueryRequests.FetchLeagues = originalFetchLeagues
+			searchEnv.Copy = originalCopy
+			searchEnv.OpenURL = originalOpenURL
+			bs.lastRealmIdx = nil
+			bs.lastLeagueIdx = nil
+			bs.lastListedIndex = nil
+			main:ClosePopup()
+		end)
+
+		local function openPopup()
+			local item = new("Item", "Rarity: Rare\nTest Ring\nRuby Ring\nImplicits: 0\n+50 to maximum Life")
+			bs.openPopup(item, "Ring", build)
+			local controls = main.popups[1].controls
+			searchEnv = getfenv(controls.search.onClick)
+			originalCopy = originalCopy or searchEnv.Copy
+			originalOpenURL = originalOpenURL or searchEnv.OpenURL
+			searchEnv.Copy = function(url) copiedUrl = url end
+			searchEnv.OpenURL = function() end
+			return controls
+		end
+
+		it("rebuilds the URL when league and listed status change", function()
+			local controls = openPopup()
+			controls.search.onClick()
+			local initialUrl = copiedUrl
+
+			controls.leagueDrop:SetSel(2)
+			controls.search.onClick()
+			assert.not_equal(initialUrl, copiedUrl)
+			assert.is_truthy(copiedUrl:find("/Standard?", 1, true))
+			local standardUrl = copiedUrl
+
+			controls.listedDrop:SetSel(4)
+			controls.search.onClick()
+			assert.not_equal(standardUrl, copiedUrl)
+			assert.is_truthy(copiedUrl:find("any", 1, true))
+		end)
+
+		it("persists popup selector choices", function()
+			local controls = openPopup()
+			controls.realmDrop.selFunc(1, "PoE2")
+			controls.leagueDrop:SetSel(2)
+			controls.listedDrop:SetSel(4)
+			main:ClosePopup()
+
+			controls = openPopup()
+			assert.equal(1, bs.lastRealmIdx)
+			assert.equal("Standard", controls.leagueDrop:GetSelValue())
+			assert.equal("Any", controls.listedDrop:GetSelValue())
+		end)
+	end)
 end)

spec/System/TestTradeHelpers_spec.lua

@@ -109,4 +109,21 @@ describe("TradeHelpers trade hash matching", function()
 			assert.equal(7, value)
 		end)
 	end)
+	describe("findTradeIdOption", function()
+		it("matches a '#'-valued option and returns its value", function()
+			local tradeId, value = tradeHelpers.findTradeIdOption("+2 to Level of all Arc Skills", "explicit")
+			assert.equal("explicit.stat_448592698|98", tradeId)
+			assert.equal(2, value)
+		end)
+
+		it("matches an exact-text option and returns no value", function()
+			local tradeId, value = tradeHelpers.findTradeIdOption("Allocates Abasement", "enchant")
+			assert.equal("enchant.stat_2954116742|7338", tradeId)
+			assert.is_nil(value)
+		end)
+
+		it("returns nil for an unmatchable line", function()
+			assert.is_nil(tradeHelpers.findTradeIdOption("+100 to IQ", "explicit"))
+		end)
+	end)
 end)

src/Classes/CompareBuySimilar.lua

@@ -330,14 +330,20 @@ function M.openPopup(item, slotName, primaryBuild)
 	if not tradeQueryRequests then
 		tradeQueryRequests = new("TradeQueryRequests")
 	end
+	local function rebuildUrl()
+		local result = buildURL(item, slotName, controls, modEntries, defenceEntries, isUnique)
+		uri = result
+	end
 
 	-- Helper to fetch and populate leagues for a given realm API id
 	local function fetchLeaguesForRealm(realmApiId)
+		local lastIdx = M.lastLeagueIdx
 		controls.leagueDrop:SetList({"Loading..."})
 		controls.leagueDrop.selIndex = 1
 		tradeQueryRequests:FetchLeagues(realmApiId, function(leagues, errMsg)
 			if errMsg then
 				controls.leagueDrop:SetList({"Standard"})
+				rebuildUrl()
 				return
 			end
 			local leagueList = {}
@@ -362,6 +368,10 @@ function M.openPopup(item, slotName, primaryBuild)
 					break
 				end
 			end
+			if lastIdx then
+				controls.leagueDrop:SetSel(lastIdx)
+			end
+			rebuildUrl()
 		end)
 	end
 
@@ -370,31 +380,36 @@ function M.openPopup(item, slotName, primaryBuild)
 	controls.realmDrop = new("DropDownControl", {"LEFT", controls.realmLabel, "RIGHT"}, {4, 0, 80, 20}, {"PoE2"}, function(index, value)
 		local realmApiId = REALM_API_IDS[value] or "poe2"
 		fetchLeaguesForRealm(realmApiId)
+		rebuildUrl()
+		M.lastRealmIdx = index
 	end)
+	if M.lastRealmIdx then
+		controls.realmDrop:SetSel(M.lastRealmIdx, true)
+	end
 	controls.realmDrop.disabled = true
 
 	-- League dropdown
 	controls.leagueLabel = new("LabelControl", {"LEFT", controls.realmDrop, "RIGHT"}, {12, 0, 0, 16}, "^7League:")
 	controls.leagueDrop = new("DropDownControl", {"LEFT", controls.leagueLabel, "RIGHT"}, {4, 0, 160, 20}, {"Loading..."}, function(index, value)
-		-- League selection stored in the dropdown itself
+		M.lastLeagueIdx = index
+		rebuildUrl()
 	end)
 	controls.leagueDrop.enabled = function() return #controls.leagueDrop.list > 0 and controls.leagueDrop.list[1] ~= "Loading..." end
 
 	-- Listed status dropdown
 	controls.listedDrop = new("DropDownControl", {"TOPRIGHT", nil, "TOPRIGHT"}, {-leftMargin, ctrlY, 242, 20}, LISTED_STATUS_LABELS, function(index, value)
-		-- Listed status selection stored in the dropdown itself
+		M.lastListedIndex = index
+		rebuildUrl()
 	end)
+	if M.lastListedIndex then
+		controls.listedDrop:SetSel(M.lastListedIndex, true)
+	end
 	controls.listedLabel = new("LabelControl", {"RIGHT", controls.listedDrop, "LEFT"}, {-4, 0, 0, 16}, "^7Listed:")
 
-	-- Fetch initial leagues for default realm
-	fetchLeaguesForRealm("poe2")
+	-- Fetch initial leagues for the selected realm
+	fetchLeaguesForRealm(REALM_API_IDS[controls.realmDrop:GetSelValue()] or "poe2")
 	ctrlY = ctrlY + rowHeight + 4
 
-	local function rebuildUrl()
-		local result = buildURL(item, slotName, controls, modEntries, defenceEntries, isUnique)
-		uri = result
-	end
-
 
 	if isUnique then
 		-- Unique item name label
@@ -483,8 +498,8 @@ function M.openPopup(item, slotName, primaryBuild)
 		-- when the trade site has a dropdown for the value, we opt to disable
 		-- the inputs as they are numeric
 		if not (entry.isOption or entry.needsExactValue) and entry.value then
-			controls[prefix .. "Min"] = tradeHelpers.newPlainNumericEdit(nil, { minFieldX - popupWidth / 2, controlYPos, fieldW, fieldH }, entry.value ~= 0 and tostring(entry.value) or "", "Min", 8, rebuildUrl)
-			controls[prefix .. "Max"] = tradeHelpers.newPlainNumericEdit(nil, { maxFieldX - popupWidth / 2, controlYPos, fieldW, fieldH }, "", "Max", 8, rebuildUrl)
+			controls[prefix .. "Min"] = tradeHelpers.newPlainNumericEdit(nil, { minFieldX - popupWidth / 2, controlYPos, fieldW, fieldH }, entry.value ~= 0 and tostring(entry.value) or "", "Min", 8, nil, rebuildUrl)
+			controls[prefix .. "Max"] = tradeHelpers.newPlainNumericEdit(nil, { maxFieldX - popupWidth / 2, controlYPos, fieldW, fieldH }, "", "Max", 8, nil, rebuildUrl)
 			if not canSearch then
 				controls[prefix .. "Min"].enabled = function() return false end
 				controls[prefix .. "Max"].enabled = function() return false end

src/Modules/ItemSlotHelper.lua

@@ -8,15 +8,15 @@ local M = {}
 ---@param w integer
 ---@param h integer
 function M.DrawViewer(itemsTab, nodeId, x, y, w, h)
+	local node = itemsTab.build.spec.nodes[nodeId]
+	if not node then return end
 	SetDrawLayer(nil, 15)
 	SetDrawColor(1, 1, 1)
 
 	local borderWidth = 1
 	DrawImage(nil, x, y, w + 2 * borderWidth, h + 2 * borderWidth)
 
 	local viewer = itemsTab.socketViewer
-	local node = itemsTab.build.spec.nodes[nodeId]
-
 	viewer.zoom = 17
 
 	local viewPortSize = math.min(w, h)