Skip to content

Commit b78f945

Browse files
authored
Fix Herald of Blood buff not applying for conditional mods (#1291)
* Fixes 1288: Herald of Blood buff not applying for conditional mods * Cleaner implementation
1 parent 7db7b97 commit b78f945

4 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/Data/Skills/act_int.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11469,7 +11469,7 @@ skills["HeraldOfIcePlayer"] = {
1146911469
statDescriptionScope = "herald_of_ice",
1147011470
statMap = {
1147111471
["display_herald_of_ice_behaviour"] = {
11472-
mod("HeraldOfIceBuff", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Ice" }),
11472+
flag("Condition:EnemiesExplode", { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Ice" }),
1147311473
},
1147411474
},
1147511475
baseFlags = {

src/Data/Skills/act_str.lua

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5244,6 +5244,11 @@ skills["HeraldOfBloodPlayer"] = {
52445244
label = "Buff",
52455245
incrementalEffectiveness = 0.054999999701977,
52465246
statDescriptionScope = "herald_of_blood",
5247+
statMap = {
5248+
["display_herald_of_blood_behaviour"] = {
5249+
flag("Condition:EnemiesExplode", { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Blood" } ),
5250+
},
5251+
},
52475252
baseFlags = {
52485253
},
52495254
stats = {

src/Export/Skills/act_int.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ end,
681681
#flags
682682
statMap = {
683683
["display_herald_of_ice_behaviour"] = {
684-
mod("HeraldOfIceBuff", "BASE", nil, 0, 0, { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Ice" }),
684+
flag("Condition:EnemiesExplode", { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Ice" }),
685685
},
686686
},
687687
#mods

src/Export/Skills/act_str.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,11 @@ statMap = {
359359
#skill HeraldOfBloodPlayer
360360
#set HeraldOfBloodPlayer
361361
#flags
362+
statMap = {
363+
["display_herald_of_blood_behaviour"] = {
364+
flag("Condition:EnemiesExplode", { type = "GlobalEffect", effectType = "Buff", effectName = "Herald of Blood" } ),
365+
},
366+
},
362367
#mods
363368
#set HeraldOfBloodExplosionPlayer
364369
#flags

0 commit comments

Comments
 (0)