Add support for Tactician's Strategic Embankments (#1961)

* add support for Tactician's Strategic Embankments

* modcache

* refactor to skill export

* modcache

Author: Peechey

src/Data/ModCache.lua

@@ -6147,7 +6147,7 @@ c["Totems have 12% additional Physical Damage Reduction"]={{[1]={flags=0,keyword
 c["Totems have 20% additional Physical Damage Reduction"]={{[1]={flags=0,keywordFlags=16384,name="PhysicalDamageReduction",type="BASE",value=20}},nil}
 c["Totems only use Skills when you fire an Attack Projectile"]={nil,"Totems only use Skills when you fire an Attack Projectile "}
 c["Totems reserve 75 Spirit each"]={{[1]={flags=0,keywordFlags=0,name="AncestralBond",type="FLAG",value=true},[2]={[1]={skillType=25,type="SkillType"},flags=0,keywordFlags=0,name="ExtraSpirit",type="BASE",value=75}},nil}
-c["Totems you place grant Embankment Auras"]={nil,"Totems you place grant Embankment Auras "}
+c["Totems you place grant Embankment Auras"]={{[1]={flags=0,keywordFlags=0,name="Condition:StrategicEmbankments",type="FLAG",value=true}},nil}
 c["Trigger Ancestral Spirits when you Summon a Totem"]={{},nil}
 c["Trigger Decompose every 1.2 metres travelled"]={nil,"Trigger Decompose every 1.2 metres travelled "}
 c["Trigger Elemental Expression on Melee Critical Hit"]={nil,"Trigger Elemental Expression on Melee Critical Hit "}

src/Data/Skills/act_int.lua

@@ -4555,6 +4555,9 @@ skills["DarkEffigyPlayer"] = {
 				totem = true,
 				duration = true,
 			},
+			baseMods = {
+				mod("Damage", "INC", 40, ModFlag.Dot, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_duration", 8000 },
 				{ "base_totem_range", 120 },

src/Data/Skills/act_str.lua

@@ -447,6 +447,9 @@ skills["AncestralWarriorTotemPlayer"] = {
 				totem = true,
 				attack = true,
 			},
+			baseMods = {
+				mod("GloryGeneration", "INC", 40, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_duration", 8000 },
 				{ "base_totem_range", 60 },
@@ -955,6 +958,12 @@ skills["ArtilleryBallistaPlayer"] = {
 				totem = true,
 				duration = true,
 			},
+			baseMods = {
+				mod("Speed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+				mod("WarcrySpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+				mod("TotemPlacementSpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+				mod("ReloadingSpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_range", 80 },
 				{ "base_totem_duration", 12000 },
@@ -13779,6 +13788,9 @@ skills["MetaMortarCannonPlayer"] = {
 				totem = true,
 				attack = true,
 			},
+			baseMods = {
+				mod("DamageGainAsFire", "BASE", 25, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_duration", 8000 },
 				{ "base_totem_range", 120 },
@@ -16758,6 +16770,9 @@ skills["ShockwaveTotemPlayer"] = {
 			baseFlags = {
 				totem = true,
 			},
+			baseMods = {
+				mod("AreaOfEffect", "INC", 30, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_duration", 12000 },
 				{ "base_totem_range", 80 },
@@ -17076,6 +17091,9 @@ skills["SiegeBallistaPlayer"] = {
 			baseFlags = {
 				totem = true,
 			},
+			baseMods = {
+				mod("Damage", "MORE", 25, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}, { type = "ActorCondition", actor = "enemy", var = "Immobilised" }),
+			},
 			constantStats = {
 				{ "base_totem_range", 80 },
 				{ "base_totem_duration", 8000 },
@@ -17401,6 +17419,9 @@ skills["SummonMetaTotemSpellTotemPlayer"] = {
 			statDescriptionScope = "summon_meta_totem_spell",
 			baseFlags = {
 			},
+			baseMods = {
+				mod("CritChance", "INC", 50, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}),
+			},
 			constantStats = {
 				{ "base_totem_duration", 8000 },
 				{ "base_totem_range", 80 },

src/Export/Skills/act_int.txt

@@ -319,6 +319,7 @@ statMap = {
 #skill DarkEffigyPlayer
 #set DarkEffigyPlayer
 #flags area spell totem duration
+#baseMod mod("Damage", "INC", 40, ModFlag.Dot, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 

src/Export/Skills/act_str.txt

@@ -26,6 +26,7 @@ local skills, mod, flag, skill = ...
 #skill AncestralWarriorTotemPlayer
 #set AncestralWarriorTotemPlayer
 #flags totem attack
+#baseMod mod("GloryGeneration", "INC", 40, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 
@@ -54,6 +55,10 @@ addFlags = {
 #skill ArtilleryBallistaPlayer
 #set ArtilleryBallistaPlayer
 #flags totem duration
+#baseMod mod("Speed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
+#baseMod mod("WarcrySpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
+#baseMod mod("TotemPlacementSpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
+#baseMod mod("ReloadingSpeed", "INC", 20, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 
@@ -799,6 +804,7 @@ statMap = {
 #skill MetaMortarCannonPlayer
 #set MetaMortarCannonPlayer
 #flags totem attack
+#baseMod mod("DamageGainAsFire", "BASE", 25, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 
@@ -977,6 +983,7 @@ statMap = {
 #skill ShockwaveTotemPlayer
 #set ShockwaveTotemPlayer
 #flags totem
+#baseMod mod("AreaOfEffect", "INC", 30, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 
@@ -992,6 +999,7 @@ statMap = {
 #skill SiegeBallistaPlayer
 #set SiegeBallistaPlayer
 #flags totem
+#baseMod mod("Damage", "MORE", 25, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"}, { type = "ActorCondition", actor = "enemy", var = "Immobilised" })
 #mods
 #skillEnd
 
@@ -1007,6 +1015,7 @@ statMap = {
 #skill SummonMetaTotemSpellTotemPlayer
 #set SummonMetaTotemSpellTotemPlayer
 #flags
+#baseMod mod("CritChance", "INC", 50, nil, nil, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "StrategicEmbankments"})
 #mods
 #skillEnd
 

src/Modules/ModParser.lua

@@ -3212,6 +3212,7 @@ local specialModList = {
 		mod("Multiplier:MainHandDamageToAllies", "BASE", num),
 	} end,
 	["projectile damage builds pin"] = { flag("CanPin", nil, ModFlag.Projectile) },
+	["totems you place grant embankment auras"] = { flag("Condition:StrategicEmbankments") },
 	-- Warrior - Smith of Kitava
 	["body armour grants armour also applies to (%a+) damage taken from hits"] = function(_, dmgType) return {
 		mod("ArmourAppliesTo"..firstToUpper(dmgType).."DamageTaken", "BASE", 100, { type = "ItemCondition", itemSlot = "Body Armour", rarityCond = "NORMAL" })