Fix staff runes showing on quarterstaves (#2218)

* Fix staff runes being listed on quarter/warstaves

* Correctly use quarterstaff for runes instead of warstaff

Author: vaisest

spec/System/TestSocketables_spec.lua

@@ -87,7 +87,7 @@ describe("TestSocketables", function()
 
     it("'(Caster) Staff' runes appear in Items tab", slotTypeTest("staff", "Voltaic Staff"))
 
-    it("'(Quarterstaff) War Staff' runes appear in Items tab", slotTypeTest("warstaff", "Striking Quarterstaff"))
+	it("'Quarterstaff' runes appear in Items tab", slotTypeTest("quarterstaff", "Striking Quarterstaff"))
 
     it("'Spear' runes appear in Items tab", slotTypeTest("spear", "Flying Spear"))
 

src/Classes/Item.lua

@@ -1566,7 +1566,7 @@ function ItemClass:UpdateRunes()
 			local itemType = self.base.type:lower()
 			local baseType = self.base.weapon and "weapon" or self.base.armour and "armour" or (self.base.tags.wand or self.base.tags.staff or self.base.tags.sceptre) and "caster"
 			local specificType =
-				(subType == "warstaff" and "warstaff") or
+				(subType == "warstaff" and "quarterstaff") or
 				(itemType == "shield" and subType == "evasion" and "buckler") or
 				itemType
 			local gatheredMods = getModRunesForTypes(name, baseType, specificType)

src/Classes/ItemsTab.lua

@@ -1942,7 +1942,7 @@ function ItemsTabClass:GetValidRunesForItem(item)
 		local function isRuneValidForSlot(runeSlot)
 			if runeSlot == "None" then
 				return true
-			elseif runeSlot == "warstaff" then
+			elseif runeSlot == "quarterstaff" then
 				return subType == "warstaff"
 			elseif runeSlot == "buckler" then
 				return itemType == "shield" and subType == "evasion"
@@ -1953,7 +1953,7 @@ function ItemsTabClass:GetValidRunesForItem(item)
 			elseif runeSlot == "caster" then
 				return item.base.tags.wand or item.base.tags.staff or item.base.tags.sceptre
 			else
-				return itemType == runeSlot
+				return itemType == runeSlot and not (subType == "warstaff")
 			end
 		end
 		if isRuneValidForSlot(rune.slot) then

src/Data/ModRunes.lua

@@ -3300,7 +3300,7 @@ return {
 				tradeHashes = { [103706408] = { "Rolls only the minimum or maximum Damage value for Physical Damage" },  },
 				rank = { 15 },
 		},
-		["warstaff"] = {
+		["quarterstaff"] = {
 				type = "Rune",
 				"Rolls only the minimum or maximum Damage value for Physical Damage",
 				"Bonded: 20% increased Bleeding Duration",
@@ -3475,7 +3475,7 @@ return {
 		},
 	},
 	["Rune of Confrontation"] = {
-		["warstaff"] = {
+		["quarterstaff"] = {
 				type = "Rune",
 				"Gain 4 Rage on Melee Hit",
 				"-10 to Maximum Rage",

src/Export/Scripts/soulcores.lua

@@ -10,10 +10,10 @@ classMap = {
 	["Armour"] = { "armour" },
 	["Wand or Staff"] = { "wand", "staff" },
 	["Maces or Talisman"] = { "one hand mace", "two hand mace", "talisman" },
-	["One Hand Mace or Quarterstaff"] = { "one hand mace", "warstaff" },
+	["One Hand Mace or Quarterstaff"] = { "one hand mace", "quarterstaff" },
 	["Shield or Buckler"] = { "shield", "buckler" },
 	["All"] = { "weapon", "armour", "caster" },
-	["Quarterstaff or Spear"] = { "warstaff", "spear" },
+	["Quarterstaff or Spear"] = { "quarterstaff", "spear" },
 	["Crossbow Bow or Spear"] = { "crossbow", "bow", "spear" },
 }