Use Characters.ot and Monsters.ot files for many magic numbers#1184
Merged
Conversation
These 2 files contain many constants we had currently hardcoded in various files Next step is to extract the ot files for all the minions we use as some of them can contain their own stats that are exclusive to the minion / monster Also fixes the base stun duration values for players and minions + the max damage reduction for impale
LocalIdentity
added
pob1
Tonkat
pushed a commit
to Tonkat/PathOfBuilding-PoE2
that referenced
this pull request
Sep 1, 2025
…fBuildingCommunity#1184) * Use Characters.ot and Monsters.ot files for many magic numbers These 2 files contain many constants we had currently hardcoded in various files Next step is to extract the ot files for all the minions we use as some of them can contain their own stats that are exclusive to the minion / monster Also fixes the base stun duration values for players and minions + the max damage reduction for impale * Weapon swap speed --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Nov 18, 2025
Port of PathOfBuildingCommunity/PathOfBuilding-PoE2#1184 These 2 files contain many constants we had currently hardcoded in various files
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Nov 18, 2025
* Use Characters.ot and Monsters.ot files for many magic numbers Port of PathOfBuildingCommunity/PathOfBuilding-PoE2#1184 These 2 files contain many constants we had currently hardcoded in various files * Fix impale tests New phys damage reduction cap was breaking them --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…fBuildingCommunity#1184) * Use Characters.ot and Monsters.ot files for many magic numbers These 2 files contain many constants we had currently hardcoded in various files Next step is to extract the ot files for all the minions we use as some of them can contain their own stats that are exclusive to the minion / monster Also fixes the base stun duration values for players and minions + the max damage reduction for impale * Weapon swap speed --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 2 files contain many constants we had currently hardcoded in various files
Next step is to extract the ot files for all the minions we use as some of them can contain their own stats that are exclusive to the minion / monster
Also fixes the base stun duration values for players and minions + the max damage reduction for impale