Show Influence icons on item headers#1199
Merged
Merged
Conversation
Wires77
approved these changes
Aug 28, 2025
Wires77
left a comment
Wires77
left a comment
Member
There was a problem hiding this comment.
This looks good, though I'm inclined to just wait to merge it until we get the official image
…uilding-PoE2 into infleunce-images
Wires77
reviewed
Sep 2, 2025
Wires77
left a comment
Wires77
left a comment
Member
There was a problem hiding this comment.
One thing this PR doesn't work on is item text copied from in game:
Item Class: Two Hand Maces
Rarity: Rare
Sol Smasher
Totemic Greatclub
--------
Quality: +5% (augmented)
Physical Damage: 178-262 (augmented)
Fire Damage: 36-48 (fire)
Critical Hit Chance: 8.18% (augmented)
Attacks per Second: 1.19 (augmented)
--------
Requires: Level 50 (unmet), 89 (unmet) Str
--------
Item Level: 50
--------
Crushes Enemies on Hit (implicit)
--------
95% increased Physical Damage
Adds 14 to 29 Physical Damage
+3.18% to Critical Hit Chance
8% increased Attack Speed
Leeches 5.82% of Physical Damage as Life
Adds 36 to 48 Fire Damage (desecrated)
It doesn't say "Desecrated Item" anywhere on it, so the desecrated flag doesn't get set
Contributor
Author
Should be fixed now. Good catch. Took a different and actually better approach instead. Not sure about the TestItem stuff though. |
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* Show Influence icons on item headers * Comment out fractured icon, get new desecrated icon * Remove Old Image * Set self.desecrated item if the item has an unveiled desecrated mod * Fix copy paste not showing icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
0.3 will have desecrated mods, and the trailer showed icons on the item header. Trade site also shows icons for fractured items.
This PR shows the icons, and allows dual influence for future proofing.
We do need to get the proper icon upon release.
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/zhm3u0q9
After screenshot:
"Desecrated Item" is in the raw item text, which makes the right icon (temp) desecrated version.
