Fix: Prevent weapon set A node allocation in weapon set B path#1233
Closed
TheDechev wants to merge 1 commit into
Closed
Fix: Prevent weapon set A node allocation in weapon set B path#1233TheDechev wants to merge 1 commit into
TheDechev wants to merge 1 commit into
Conversation
TheDechev
force-pushed
the
fix/prevent-weapon-sets-wrong-node-allocations
branch
2 times, most recently
from
3f42ffd to
3f2ad78
Compare
Wires77
reviewed
Sep 2, 2025
| local connectedToWeaponSetNodes = self:IsConnectedToWeaponSetNodes(node) | ||
| return weaponSetMode or connectedToWeaponSetNodes | ||
| else | ||
| return not self:PathCrossesWeaponSets(node, spec) |
Member
There was a problem hiding this comment.
This function doesn't exist, so I get an error when pathing past a jewel socket:
Contributor
Author
There was a problem hiding this comment.
@Wires77 - crap, I did some last minute cleanups and this got missed.
Try again, it should be okay now.
• Add GetNodeBlockingReason() with detailed validation for different blocking scenarios • Unify allocation/deallocation blocking in shouldBlockNodeAllocation() and shouldBlockNodeDeallocation() • Implement connection-based validation that checks entire path connectivity • Add specific tooltip warnings for global nodes, path crossing, and path through globals • Support directional weapon set compatibility (weapon sets connect to main tree, not vice versa)
TheDechev
force-pushed
the
fix/prevent-weapon-sets-wrong-node-allocations
branch
from
3f2ad78 to
4d5a2cc
Compare
Contributor
Author
|
As discussed privately this might be a minor improvement, but it changes the convenient allocation behavior and therefore it'll be abandoned for now to prioritize UX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix weapon set path crossing allocation
Summary
Fixes a bug where users could allocate nodes across different weapon sets through path crossing. Users could allocate a node for weapon set 2 even if the only path went through nodes allocated to weapon set 1.
Changes Made
Weapon Set Path Validation
• Added
GetNodeBlockingReason()with detailed validation logic for different blocking scenarios• Unified allocation/deallocation blocking in
shouldBlockNodeAllocation()andshouldBlockNodeDeallocation()functions• Connection-based validation checks entire path connectivity including linked nodes
Enhanced User Warnings
• Specific tooltip messages for different blocking reasons (global nodes, path crossing, path through globals)
• Integrated with existing global node warning system
Optimized Validation Logic
• Efficient set-based path checking eliminates nested loops
• Unified direct link and path validation handling
• Directional weapon set compatibility (weapon sets can connect to main tree, not vice versa)
Images
Validations
• Tested weapon set switching and cross-weapon-set allocation attempts
• Verified far node allocation works correctly within same weapon set
• Confirmed blocking works for paths through global nodes while in weapon set mode
• Ensured tooltip warnings appear correctly with specific guidance