Skip to content

Fix incorrect radius on Explosive Spear #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Sep 4, 2025
Merged

Fix incorrect radius on Explosive Spear #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Data/Skills/act_dex.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2584,6 +2584,7 @@ skills["ExplosiveSpearPlayer"] = {
{ "base_number_of_remote_spear_mines_allowed", 1 },
{ "active_skill_base_physical_damage_%_to_convert_to_fire", 60 },
{ "remote_spear_mine_minimum_target_distance", 10 },
{ "active_skill_base_area_of_effect_radius", 28 },
{ "active_skill_base_physical_damage_%_to_convert_to_fire", 40 },
},
stats = {
Expand Down Expand Up @@ -2660,6 +2661,7 @@ skills["ExplosiveSpearPlayer"] = {
{ "base_number_of_remote_spear_mines_allowed", 1 },
{ "active_skill_base_physical_damage_%_to_convert_to_fire", 60 },
{ "remote_spear_mine_minimum_target_distance", 10 },
{ "active_skill_base_area_of_effect_radius", 40 },
{ "active_skill_base_secondary_area_of_effect_radius", 15 },
{ "active_skill_base_tertiary_area_of_effect_radius", 20 },
{ "active_skill_base_physical_damage_%_to_convert_to_fire", 40 },
Expand Down
15 changes: 15 additions & 0 deletions src/Export/Scripts/skills.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,25 @@ directiveTable.set = function(state, args, out)
statRow.InterpolationBases = tableConcat(baseStatRow.InterpolationBases, statRow.InterpolationBases)
statRow.AdditionalStats = tableConcat(baseStatRow.AdditionalStats, statRow.AdditionalStats)
statRow.AdditionalStatsValues = tableConcat(baseStatRow.AdditionalStatsValues, statRow.AdditionalStatsValues)
statRow.BaseStats = tableConcat(tableConcat(tableConcat(skill.baseGrantedEffectStatSet.ImplicitStats, skill.baseGrantedEffectStatSet.ConstantStats), baseStatRow.FloatStats), baseStatRow.AdditionalStats)
end
level.statInterpolation = statRow.StatInterpolations
level.actorLevel = statRow.ActorLevel
local tempRemoveStats = copyTable(set.removeStats, true)
for i, removeStat in pairs(set.removeStats) do
-- Fixes the case where a removeStat does not exist in the base set but does in future sets
-- It should not be removed if this is the case
local remove = false
for _, stat in ipairs(statRow.BaseStats) do
if stat.Id == removeStat then
remove = true
end
end
if remove == false then
table.remove(tempRemoveStats, i)
table.remove(set.removeStats, i)
end
end
local resolveInterpolation = true
local injectConstantValuesIntoEachLevel = false
local statMapOrderIndex = 1
Expand Down