Skip to content

Feat: Implement trade mode selection#1289

Closed
Mizkii wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Mizkii:trade-mode-selection
Closed

Feat: Implement trade mode selection#1289
Mizkii wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Mizkii:trade-mode-selection

Conversation

@Mizkii

@Mizkii Mizkii commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This PR introduces a "Trade Mode" dropdown to the Trader pane, giving users control over the online status of their item searches. Previously, all weighted searches were hardcoded to "In Person Trade Only" (online). This change allows users to specify their preferred trade method, enabling searches for items with instant buyouts or including offline listings.

The four available options are:

  • Instant Buyout and In Person Trade (available)
  • Instant Buyout Only (securable)
  • In Person Trade Only (online)
  • Any (any)

Steps taken to verify a working solution:

  • Opened the Trader pane and selected each of the four options from the new "Trade Mode" dropdown.
  • Generated a "Find best" weighted search for an item slot for each selection.
  • Verified that the resulting trade query correctly used the corresponding status option (available, securable, online, any).
  • Confirmed that the default selection is "In Person Trade Only" to maintain the previous default behavior.

Link to a build that showcases this PR:

Not applicable. This is a core feature enhancement for the Trader and is not build-specific.

Before screenshot:

image

**
The Trader pane UI before this change, with no option to select the trade mode in the bottom-right corner.

After screenshot:

image

**
The Trader pane UI with the new "Trade Mode" dropdown displayed in the bottom-right corner.

@diogofr4

diogofr4 commented Sep 3, 2025

Copy link
Copy Markdown

If I try to use "Any" or "Instant Buyout and In Person Trade" and then click on Find best, the list only returns items from Instant Buyout. The search link it's correct though

@Mizkii

Mizkii commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

If I try to use "Any" or "Instant Buyout and In Person Trade" and then click on Find best, the list only returns items from Instant Buyout. The search link it's correct though

maybe the best items are on instant buy , i have added direct whisper and teleport , dunno maybe ill upload today or tomorrow , need to test it.

@Mizkii Mizkii closed this Sep 4, 2025
@LocalIdentity

Copy link
Copy Markdown
Contributor

Any reason you closed the PRs @Mizkii ?

@Mizkii

Mizkii commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

Any reason you closed the PRs @Mizkii ?

Yes, I want to merge this with #1293, since I think these things depend on each other. Also, #1293 needs more testing since it crashed twice today, so I closed this one and #1293 for now.

Big thanks for your time and the work you're doing here 👍

@Mizkii Mizkii deleted the trade-mode-selection branch September 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants