Skip to content

Automatically check if the ModCache needs to be regenerated#1362

Merged
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
Musholic:check_modcache_ci
Sep 13, 2025
Merged

Automatically check if the ModCache needs to be regenerated#1362
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
Musholic:check_modcache_ci

Conversation

@Musholic

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Add a github CI job to automatically check if the ModCache needs to be regenerated

You can see an example of the test failing on Musholic#2

@LocalIdentity LocalIdentity added the technical Hidden from release notes label Sep 12, 2025

@Wires77 Wires77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only issue I have with this is that maybe it should be its own action. We explicitly removed this type of functionality in PathOfBuildingCommunity/PathOfBuilding#6694 because it would slow down the tests.

If you wanted to get fancy, you could check the PR to see if it was updating ModCache already, because if so you wouldn't need to run this check.

@Musholic

Copy link
Copy Markdown
Contributor Author

I think the only issue I have with this is that maybe it should be its own action. We explicitly removed this type of functionality in PathOfBuildingCommunity/PathOfBuilding#6694 because it would slow down the tests.

If you wanted to get fancy, you could check the PR to see if it was updating ModCache already, because if so you wouldn't need to run this check.

The check is actually running in parallel and separately from the run_tests job and does not slow it down, so it's all good on this part

@Wires77 Wires77 merged commit ed952e9 into PathOfBuildingCommunity:dev Sep 13, 2025
3 checks passed
bct8925 pushed a commit to bct8925/PathOfBuilding-PoE2 that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants