Trader tool: OAuth support, match mods by tradeHash (fixes many local and essence mods), add price sorting, add radius jewels, notice when rate limited#1801
Merged
LocalIdentity merged 44 commits intoMay 25, 2026
Conversation
This was referenced Apr 19, 2026
9811d7c to
0d2a6a9
Compare
vaisest
commented
Apr 21, 2026
88aca9f to
ddb73c8
Compare
vaisest
commented
Apr 25, 2026
7b85bf4 to
1bddcdc
Compare
Contributor
Author
|
I rebased this onto dev now that the base PR is merged. Everything seems to work the same. |
Nightblade
reviewed
May 19, 2026
Contributor
Author
|
The trade hash generation issue is now also fixed here, which means that physical % mods on weapons get generated correctly. Now surely all mods are generated correctly. |
…shes in a similar format as previous mod export changes.
LocalIdentity
approved these changes
May 25, 2026
This was referenced May 25, 2026
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
… and essence mods), add price sorting, add radius jewels, notice when rate limited (PathOfBuildingCommunity#1801) * port compatible trader tool changes from pob1 * Fix corrupted mods being fractured mods in trade mod generation * Fix radius jewel weight generation * Regenerate QueryMods.lua * convert trade tool mod weight generation to use tradeHash * wip: change poesessid to bearer token * Cleanup: remove extra logout button and fix poeapi comments * Fix trader crash when rate limited on startup * Use https://poe.ninja/poe2/api/economy/exchange/current/overview for currency rates * Fix poe.ninja tests * Fix trader section anchor * Adjust price scaling factor due to things being in divs (still an abitrary number) * Clarify price options and rate limit waits, and use Retry-After for rate limiting waits if possible * rate limiting pls work * Fix perfect essences not appearing in generated weights, and regenerate querymods.lua * Fix tradehashes for radius jewels * Improve rate limit countdown to prevent simplegraphic suspension problems, and to show it on non-429 rate limit. (429 issue solved on GGG's side) * Fix debug print causing crash, and remove extra debug print * disable wiping trader controls to fix crash when it is closed and a search tries to add results to controls * Add note about doing weird filter requirements (e.g. adorned) * remove whisper for instant buyout items * make cspell happy * Fix database radius jewels being nonfunctional * Fix currency conversion button not being updated after reopening trader panel * Avoid useless search in "search for" button * fix api error on invalid token * disable reuseaddr * Rework OAuth server launch code to avoid shared port usage * Remove error code on login and fix hanging item slot controls in tradequery * Fix QueryMods.lua generation. Change soulcores.lua to export trade hashes in a similar format as previous mod export changes. * Add note about trade hashes * Fix curse querymod.lua test * Clear authorization on 403 to fix outdated scope in trader * Use enum in mods.lua and format it * Fix typo in mods.lua * Fix module being a global variable and compare trade helpers into one file * Remove forgotten debug prints * Fix trade hash generation * add note about radius jewel mods * Fix rune weight generation and regenerate QueryMods.lua * Fix whitespace in related files * Fix error handling on oauth login * Fix price sum sorting in trade * Move print call so it doesn't get spammed in tests --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1409, #1314, #748, #993, #1667, #185, #1748
#469 might be related
Description of the problem being solved:
Most of these changes could probably be ported to pob1 for consistency.
Steps taken to verify a working solution:
Possible issues
I had problems with 429 rate limiting. I'm not sure if that's because of me mashing f5 to test changes, or a real issue.Issue was caused by Cloudflare, fixed by GGG.
Radius jewels don't generate a weight for the mod that increases the radius. I'm not sure how this should be generated as its value depends purely on the other mods on the jewel. This only affects the weighted sum, though. I'm not sure if it's worth paying attention to. For my build, it's sort of useless, but if it has a large impact, we could assign a manual weight to it to not exclude it from the weighted sum. In the sorting done in PoB, it is taken into account.
Some modifiers don't seem to get tested. I don't think this is a trader issue, but rather that GGG hasn't assigned spawn weights to some mods. For example, the jewel resistance corruptions only have a default tag. This seems to have been a problem in the past too as seen in #1269.
Link to a build that showcases this PR:
Nothing specific, but:
Before screenshot:
(not sure why the previous version doesn't work at all)

body:

amulet:

After screenshot:
body:

amulet:

In search results it should also be clear that more mods are generated. For example a lot essence mods and local-only mods were previously missing which made results very bad.
Depends on #1830