Add support for Deadeye's Thrilling Chase and Heightened Charges support#1860
Merged
LocalIdentity merged 3 commits intoMay 18, 2026
Merged
Conversation
add support for Heightened Charges fix Rain of Arrows consumed frenzy mod
LocalIdentity
approved these changes
May 18, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I made the code much simpler by making the mods use Multiplier: so we could get rid of all the special handling in CalcPerform
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…ort (PathOfBuildingCommunity#1860) * add support for Deadeye's Thrilling Chase add support for Heightened Charges fix Rain of Arrows consumed frenzy mod * test * Simplify changes --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
Description of the problem being solved:
Adding support for "benefits from charges have x% chance to be doubled" by adding a scalar tag to Multiplier and MultiplierThreshold mods.
Also fixing a bug with Rain of Arrows "more projectile if consumed a frenzy" mod, we had ProjectileNumber instead of ProjectileCount.
I did test Thrilling Chase and Heightened Charges together for an expected 70% chance to be doubled, but there was an issue with how I was getting the Sum for "ConsumedFrenzyChargeEffect" for the activeSkill so I do subtract the Thrilling Chase mod so we don't double dip. I don't know if that's the best solution but if I didn't the activeSkill.multiplier was grabbing 70 instead of 20. You can see the change around 1193 of CalcPerform.
Added a test to validate Thrilling Chase and Heightened Charges play nice.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
thrilling chase
spiral volley is 100% if consumed frenzy, 30% per frenzy
heightened charges
spiral volley is 100% if consumed frenzy, 30% per frenzy
thrilling chase + heightened charges
rain of arrows
