Reduce EstimatePlayerProgress calls#1972
Merged
LocalIdentity merged 1 commit intoMay 26, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 26, 2026
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
We're calling EstimatePlayerProgress in a width function that is called onFrame all the time. It's a TON and I wanna stop that, so I'm moving the call to RefreshStatList which is called every buildFlag, which might still be too often but much much less.
Note during the first gif, the before, I hover over some tree nodes which spikes the kB usage. Keep an eye on the gain rate when nothing is happening towards the end of the gif and compare that to the after gain rate. PS: I don't know if this actually means anything, graphics have never been my strong suit 😆
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: