Add support for 0.5 JSON skill tree#1984
Merged
LocalIdentity merged 19 commits intoMay 28, 2026
Merged
Conversation
justjuangui
force-pushed
the
feat/passivetree
branch
from
d0dc2ca to
64f1d46
Compare
added 9 commits
May 27, 2026 13:24
… in passive tree script
…ns for Druid nodes
- Enhanced passivetree_ggg.lua to support aliasNotableMap for jewel sockets.
justjuangui
force-pushed
the
feat/passivetree
branch
from
64f1d46 to
5f4d83f
Compare
added 2 commits
May 27, 2026 19:43
…g related logic in passive tree
Nightblade
reviewed
May 28, 2026
Comment on lines
+18
to
+35
| local multiplier = 10 ^ decimal_places | ||
| return math.floor(num * multiplier + 0.5) / multiplier | ||
| end | ||
|
|
||
| local function arcDirection(fromNode, toNode, edge) | ||
| -- vectors from arc center to each node | ||
| local v1x = fromNode.x - edge.orbitX | ||
| local v1y = fromNode.y - edge.orbitY | ||
| local v2x = toNode.x - edge.orbitX | ||
| local v2y = toNode.y - edge.orbitY | ||
|
|
||
| -- signed angle from v1 to v2, in (-pi, pi] | ||
| local dot = v1x * v2x + v1y * v2y | ||
| local cross = v1x * v2y - v1y * v2x | ||
| local angle = math.atan2(cross, dot) | ||
|
|
||
| return cross > 0 and -1 or 1 | ||
| end |
Contributor
There was a problem hiding this comment.
There's some space-indentation here. Could be more, I've not checked the whole file.
Contributor
Author
|
Abyssal Lich |
Nightblade
reviewed
May 28, 2026
| end | ||
| end | ||
| -- build orbits info | ||
| -- spell-checker: disable |
Contributor
There was a problem hiding this comment.
I've updated cspell to ignore *orbit_intermediateactive* so this and the other tag can go.
added 7 commits
May 29, 2026 04:01
Old builds from 0.1 to 0.3 used the wrong id for the character class and opening them now would convert them to the wrong class. This maps the old builds so they now open correctly
Was using the wrong name from a previous commit
Uses the tree data folder to look for the ggg assets and json files Fixes the tree file changing each time on export due to pairs usage
Now runs in 0.1s instead of 8s
LocalIdentity
approved these changes
May 28, 2026
LocalIdentity
changed the title
LocalIdentity
merged commit eca470e
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
jay9297
added a commit
to jay9297/PathOfBuilding-PoE2
that referenced
this pull request
May 29, 2026
* Chore: Bump action version numbers (PathOfBuildingCommunity#1993) * Add support for Legacy Grand Spectrum mods (PathOfBuildingCommunity#1994) Some old mods don't require the socketed in text Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for Ancestral Empowerment, Ancestral Call, Crescendo II and III, Infernal Cry, and "Ancestrally Boosted Attacks" passive nodes (PathOfBuildingCommunity#1839) * add support for Ancestral Call, Crescendo II and III, ancestral boost tree nodes * fix ancestral call inc dmg from tree * big ole refactor so we stop duplicating code one commit so I can revert if it goes boom * added test update CalcSection from "Exerted Warcries" to "Ancestral Boosts" * add data map for gemName given a modSource * boosted attacks configOption * add support for Ancestral Empowerment, including combining Ancestral Empowerment with Fist of War fix Fist of War/ancestrally boosted slams more AOE to inc AOE add test for Combined logic for Ancestral Empowerment and Fist of War * comment spelling * better label * fix avg aoe from fist of war * forgot AOE portion for Crescendo III * add support for Infernal Cry's empowered buff * refactor away from specific baseMod for FistOfWar fix Ancestral Empowerment not getting the double from fist of war III * empowered condition for all Ancestrally Boosted * ancestralBoostEffect * multiplier instead * pr comments also refactored Crescendo III to use the new logic instead of an extra isolated block of logic by introducing a way to conditionally max uptime for Boosted or Empowered attacks * Fix issues Move the Infernal Cry buff to calc offence so it doesn't rely on stale calc output Fix Ancestral Empowerment uptime calculation Move gain table so Infernal Cry still works * Fix spelling --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Add support for 0.5 JSON skill tree (PathOfBuildingCommunity#1984) * Passive tree parser from ggg web data * enhanced escapeGGGString * Fix ascendancy unlock constraint check in node search parameters * Refactor DrawQuadAndRotate to handle different data lengths for vertex calculations * Add node overlay for Blighted Notable Frames in passive tree * Fix typos and improve comments in passive tree script * Fix typos in ascendancy handling and update inner radius calculations in passive tree script * Refactor passive tree node replacement logic and add switchable options for Druid nodes * Add support for alias notable maps and enhance jewel socket handling - Enhanced passivetree_ggg.lua to support aliasNotableMap for jewel sockets. * Rename aliasNotableMap to aliasPassiveSocket for clarity in passive tree data * Enhance jewel socket handling by adding noRadius property and updating related logic in passive tree * Enable Abyssal Lich parser * Fix tests Export ModCache Fix crash with class Ids Fix unarmed data for Ids * Add legacy class ID remap Old builds from 0.1 to 0.3 used the wrong id for the character class and opening them now would convert them to the wrong class. This maps the old builds so they now open correctly * Formatting + typos * AliasPassiveSocket fix Was using the wrong name from a previous commit * Export fixes Uses the tree data folder to look for the ggg assets and json files Fixes the tree file changing each time on export due to pairs usage * Use copy file command to speed up export Now runs in 0.1s instead of 8s --------- Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> * Remove aliasPassiveSocket temp code * Fix Hollow Palm Technique parsing and add Spectral Ward support - Make 'rating' optional in evasion suffix patterns (r?a?t?i?n?g?) - Remove dead-code keystone pattern with wrong parameter order - Add bounds check for hollowPalmAddedPhys table (levels 1-40) - Add descriptive line patterns for Hollow Palm Technique node - Add Spectral Ward pattern for 'per X item evasion on equipped body armour' - Update ModCache entries for all affected patterns --------- Co-authored-by: Nighty <Nightblade@users.noreply.github.com> Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com> Co-authored-by: Juangui <80857657+justjuangui@users.noreply.github.com> Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: jay9297 <jay9297@users.noreply.github.com>
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* Passive tree parser from ggg web data * enhanced escapeGGGString * Fix ascendancy unlock constraint check in node search parameters * Refactor DrawQuadAndRotate to handle different data lengths for vertex calculations * Add node overlay for Blighted Notable Frames in passive tree * Fix typos and improve comments in passive tree script * Fix typos in ascendancy handling and update inner radius calculations in passive tree script * Refactor passive tree node replacement logic and add switchable options for Druid nodes * Add support for alias notable maps and enhance jewel socket handling - Enhanced passivetree_ggg.lua to support aliasNotableMap for jewel sockets. * Rename aliasNotableMap to aliasPassiveSocket for clarity in passive tree data * Enhance jewel socket handling by adding noRadius property and updating related logic in passive tree * Enable Abyssal Lich parser * Fix tests Export ModCache Fix crash with class Ids Fix unarmed data for Ids * Add legacy class ID remap Old builds from 0.1 to 0.3 used the wrong id for the character class and opening them now would convert them to the wrong class. This maps the old builds so they now open correctly * Formatting + typos * AliasPassiveSocket fix Was using the wrong name from a previous commit * Export fixes Uses the tree data folder to look for the ggg assets and json files Fixes the tree file changing each time on export due to pairs usage * Use copy file command to speed up export Now runs in 0.1s instead of 8s --------- Co-authored-by: justjuangui <servicios@juacarvajal.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.