Fix orbit values for passive nodes and connection rendering (arcs vs lines)#1998
Merged
LocalIdentity merged 1 commit intoMay 29, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 29, 2026
009a7c5
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…astery nodes (PathOfBuildingCommunity#1998) Co-authored-by: justjuangui <servicios@juacarvajal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the orbit values for passive nodes and updates node overlays for
non-mastery nodes. It also corrects how passive tree connections are rendered by
distinguishing between arcs and straight lines based on the connection orbit data.
Background
When building the passive tree from
data.json, the orbit value of a connectiondetermines whether it should be drawn as an arc or a straight line. This
mirrors the behavior found in the PSG file. The same orbit data also affects how
non-mastery node overlays are positioned.
Details
Connection rendering (arcs vs lines)
In the PSG file, a connection orbit can hold one of two values:
0→ the connection is an arc on that orbit0x7FFFFFFF→ the connection is a straight lineThe
data.jsonfile follows the same pattern, expressed differently:orbit: 0withorbitXandorbitY→ arcorbit: 0withoutorbitXandorbitY→ straight lineChanges
orbitXandorbitYto determine theconnection type, and render arcs vs straight lines accordingly.
Validation
Screenshots are attached below for visual verification.