Skip to content

Update quest rewards for 0.5#2027

Merged
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
rasmuskl:quest-rewards-0.5
Jun 1, 2026
Merged

Update quest rewards for 0.5#2027
Wires77 merged 1 commit into
PathOfBuildingCommunity:devfrom
rasmuskl:quest-rewards-0.5

Conversation

@rasmuskl

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

0.5 API now serves quest_stats as aggregated instead of exact lines per quest. So the +30/30/40 lines for spirit becomes a single +100 line instead. This PR adds a simple greedy algorithm to configure quests in import by decomposing the rolled up values.

Adds a simple disambiguation table for spirit specifically, since the 30+30+40 spirit values can result in wrong values with the greedy algorithm. An alternative solution would be to try all combinations, but I decided to keep it simple since it was only a single case to avoid the additional complexity.

Also added the new Tribal Medicine quest: https://poe2db.tw/us/Tribal_Medicine

Steps taken to verify a working solution:

Added new tests and tested in UI.

@Wires77 Wires77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying change, but thanks for the quick fix and tests

@Wires77 Wires77 changed the title Quest rewards 0.5 Update quest rewards for 0.5 Jun 1, 2026
@Wires77 Wires77 added the bug: calculation Numerical differences label Jun 1, 2026
@Wires77 Wires77 merged commit b21d413 into PathOfBuildingCommunity:dev Jun 1, 2026
4 of 5 checks passed
bct8925 pushed a commit to bct8925/PathOfBuilding-PoE2 that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants