Add support for various Parry modifiers (Debuff Magnitude, Range, Duration)#2080
Merged
LocalIdentity merged 12 commits intoJun 5, 2026
Merged
Conversation
Adds processing of "<DebuffName>Magnitude" modifiers, in addition to existing checks for generif "DebuffEffect" and skill-specific "Magnitude" modifiers
- Moved the process of Debuff to `skillStatMap` as "Refutation" introduced new ways to gain access to parry debuff - Changed the mod details slightly to enable better debuff processing
Parry duration hasn't been processed at all yet, and mods affecting Parry range currently false apply to the weapon range used for the Parry attack, rather than blocking distance
Makes it easier to reuse in other contexts. No functional change otherwise
Includes: - Parsing of mods - Calculation and adding to `output` - Breakdowns for each stat in CalcsSections
Also slight changes to calculation approach in `CalcPerform` as it previously didn't account for debuff effect being multiplicative
Automatically tests: - parry debuff increases damage when active - parry magnitude further increases damage - parry debuff does not affect spell damage NOTE: that last one will have to be adjusted once we support the mod that changes parry to apply to spell damage instead, but I guess that's what the test is for...
The base stat divides by 10 so you have a base range of 1m
LocalIdentity
approved these changes
Jun 5, 2026
LocalIdentity
merged commit ee0e4b7
into
PathOfBuildingCommunity:dev
4 of 5 checks passed
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…ation) (PathOfBuildingCommunity#2080) * Add mod parsing for Parried Debuff Magnitude * Add specific debuff magnitude processing Adds processing of "<DebuffName>Magnitude" modifiers, in addition to existing checks for generif "DebuffEffect" and skill-specific "Magnitude" modifiers * Change processing of Parry debuff stats - Moved the process of Debuff to `skillStatMap` as "Refutation" introduced new ways to gain access to parry debuff - Changed the mod details slightly to enable better debuff processing * Add stats for Parry duration and range Parry duration hasn't been processed at all yet, and mods affecting Parry range currently false apply to the weapon range used for the Parry attack, rather than blocking distance * Separate buff expiry function from skill duration Makes it easier to reuse in other contexts. No functional change otherwise * Enable parry debuff recognition for "Refutation" * Add support for Parry Debuff Duration & Range mods Includes: - Parsing of mods - Calculation and adding to `output` - Breakdowns for each stat in CalcsSections * Add breakdown for parry debuff magnitude Also slight changes to calculation approach in `CalcPerform` as it previously didn't account for debuff effect being multiplicative * Make parry config option available for other skills * Fix config option not appearing for other skills * Add parry test to `TestSkills_spec.lua` Automatically tests: - parry debuff increases damage when active - parry magnitude further increases damage - parry debuff does not affect spell damage NOTE: that last one will have to be adjusted once we support the mod that changes parry to apply to spell damage instead, but I guess that's what the test is for... * Fix parry range not dividing by 10 The base stat divides by 10 so you have a base range of 1m --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Previous implementation of the Parry Debuff was not fully supported and could not be scaled.
This PR adds support for
Steps taken to verify a working solution:
TestSkills_spec.lua(only for basic tests)Link to a build that showcases this PR:
https://pobb.in/VmoLNcYh04kO
After screenshot:
Mod Parsing
Magnitude
Duration
Range
Breakdowns
Parry Debuff from Refutation
Magnitude breakdown
Duration breakdown
Range (Non-proj) breakdown
Range (Proj) breakdown
