Buy similar: combine same stats from different mods#2118
Merged
LocalIdentity merged 6 commits intoJun 10, 2026
Conversation
Contributor
Author
|
While taking screenshots I noticed the fields floor float values and didn't accept floats. This seems a bit misleading for e.g. flat crit so in the last commit I made mod fields float valued. Many mods use integer values, but even if the user inputs a float, it shouldn't affect anything since the trade site seems to floor them (though don't quote me on that) |
Regex was wrong and was rejecting integers Unsupported mods text issue
LocalIdentity
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes trade search for repeated mods with the same stats. For example breath of aldur weapons or items with resistances transformed to chaos res.
to # mods now also use the midpoint for the search.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/xLtX_75reIyy
Before screenshot:
The resulting trade search was also wrong as it only takes into account the first filter for each stat.
After screenshot: