Skip to content

Buy similar: combine same stats from different mods#2118

Merged
LocalIdentity merged 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:buy-similar-sum-mods
Jun 10, 2026
Merged

Buy similar: combine same stats from different mods#2118
LocalIdentity merged 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:buy-similar-sum-mods

Conversation

@vaisest

@vaisest vaisest commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes trade search for repeated mods with the same stats. For example breath of aldur weapons or items with resistances transformed to chaos res.

to # mods now also use the midpoint for the search.

Steps taken to verify a working solution:

  • Tested with various items from the trade site

Link to a build that showcases this PR:

https://pobb.in/xLtX_75reIyy

Before screenshot:

image

The resulting trade search was also wrong as it only takes into account the first filter for each stat.

After screenshot:

image image image

@vaisest vaisest changed the title Buy similar: Fix repeated mods resulting from new runes Buy similar: combine same stats from different mods Jun 9, 2026
@vaisest

vaisest commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

While taking screenshots I noticed the fields floor float values and didn't accept floats. This seems a bit misleading for e.g. flat crit so in the last commit I made mod fields float valued. Many mods use integer values, but even if the user inputs a float, it shouldn't affect anything since the trade site seems to floor them (though don't quote me on that)

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jun 10, 2026
Regex was wrong and was rejecting integers
Unsupported mods text issue
@LocalIdentity LocalIdentity merged commit 859cd82 into PathOfBuildingCommunity:dev Jun 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants