Skip to content

Add trader support for Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods and Breach tree mods#2121

Merged
LocalIdentity merged 11 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-hotw
Jun 10, 2026
Merged

Add trader support for Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods and Breach tree mods#2121
LocalIdentity merged 11 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-hotw

Conversation

@vaisest

@vaisest vaisest commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This adds to the trader:

  • Heart of the Well
  • Against the Darkness
  • Desecrated mods (many of them were just regular mods, but desecrate-only mods are now also present)
  • Rune influenced mods (can roll X runes) (Meta mods like increased stat magnitudes will still do nothing (though they ARE taken into account as the trade site uses the old format which includes the effect in the resulting item text))
  • Breach belt and ring mods

Steps taken to verify a working solution:

  • Testing with my build
  • Some specifics like a couple breach mods were also tested manually

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

Panel widened slightly:

image image

@vaisest vaisest marked this pull request as draft June 7, 2026 14:27
@vaisest vaisest marked this pull request as ready for review June 7, 2026 16:44
@vaisest vaisest changed the title Trader: Heart of the Well, Against the Darkness, Desecrated mods Trader: Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods Jun 7, 2026
@vaisest vaisest changed the title Trader: Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods Trader: Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods, Breach tree mods Jun 8, 2026
@vaisest

vaisest commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

One issue I found while testing this PR was that the weights can be very confusing for minion builds. By default the idea is to use your stats, but if minions do all of your damage and you don't have full DPS set up, your dps weight will be zero.

Not sure what the best approach here is. I imagine if both you and your minions do damage, it's not a good idea to only use one of them

vaisest and others added 3 commits June 8, 2026 19:59
Fix crash on no jewel socket
Fix tooltip and calc to use selected socket
@LocalIdentity LocalIdentity merged commit ace17cc into PathOfBuildingCommunity:dev Jun 10, 2026
5 checks passed
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jun 10, 2026
@LocalIdentity LocalIdentity changed the title Trader: Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods, Breach tree mods Add trader support for Heart of the Well, Against the Darkness, Desecrated mods, Rune-only mods and Breach tree mods Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants