Add Bloodbarrier support#2125
Merged
LocalIdentity merged 3 commits intoJun 10, 2026
Merged
Conversation
LocalIdentity
approved these changes
Jun 10, 2026
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fxed a bunch of issues with the PR
There was not export of the skill from other.txt
The gem.lua file is autogenerated from game data so you can't add to it
The FullDPS logic was not needed as PoB already handles corrupted blood DPS and only applies the strongest one
The SkillGems.txt file is auto-generated from game data, so it should not be edited
The formatting of the ModParser lines was not in keeping with the existing layout and in the wrong position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Bloodbarrier.
Description of the problem being solved:
isSkillIncludedInFullDPSto Calcs.lua that will work with extra/generated skills.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/b-PE53yEnGTe
Before screenshot:
After screenshot: