Skip to content

Add Bloodbarrier support#2125

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
DS-Koala:Bloodbarrier
Jun 10, 2026
Merged

Add Bloodbarrier support#2125
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
DS-Koala:Bloodbarrier

Conversation

@DS-Koala

@DS-Koala DS-Koala commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Fixes Bloodbarrier.

Description of the problem being solved:

  • Bloodbarrier was not supported as a calculated skill in Path of Building 2.
  • Once created as an ExtraSkill, it still would not show up in Full DPS. Added a function isSkillIncludedInFullDPS to Calcs.lua that will work with extra/generated skills.

Steps taken to verify a working solution:

  • Added Bloodbarrier to a build and confirmed it appears in the Skills tab.
  • Confirmed Bloodbarrier calculates its Corrupted Blood damage correctly in the skill breakdown.
  • Checked "Show in Full DPS" for Bloodbarrier and confirmed the damage is included in Full DPS.

Link to a build that showcases this PR:

https://pobb.in/b-PE53yEnGTe

Before screenshot:

image

After screenshot:

image

DS-Koala and others added 2 commits June 7, 2026 16:16
Fix the formatting of ModParser
Fix inclusion of skill in FullDPS
Add export in other.txt
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jun 10, 2026

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fxed a bunch of issues with the PR
There was not export of the skill from other.txt
The gem.lua file is autogenerated from game data so you can't add to it
The FullDPS logic was not needed as PoB already handles corrupted blood DPS and only applies the strongest one
The SkillGems.txt file is auto-generated from game data, so it should not be edited
The formatting of the ModParser lines was not in keeping with the existing layout and in the wrong position

@LocalIdentity LocalIdentity merged commit afbbb7d into PathOfBuildingCommunity:dev Jun 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants