Add support for various ailment and debuff mods#2134
Merged
LocalIdentity merged 7 commits intoJun 10, 2026
Conversation
There were different wording variations for mods that affect ailment magnitude on players or enemies. Some of which were not recognized yet. Example: - "magnitude of ignite you inflict" was recognized - "magnitude of ignite on ... enemies" was not recognized
Equivalent to `SumPositiveValues()`, but for negative values instead. In this case usefuly to calculate whether the enemy is "slowed"
NOTE: I am not 100% sure that this is the perfect place for this processing to go, but it needed to be somewhere after all the other debuffs like chill, maim, curses, etc. have been processed
Added to `flagTypes` to enable parsing of nearby enemies are ... type of mods for those conditions
This was only done for "Maimed" before
LocalIdentity
approved these changes
Jun 10, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
Should probably fix the parsing of mods like Nearby Enemies are Hindered, with 25% reduced Movement Speed so that it uses the hindered speed value but is fine for now as nothing actually cares about the speed atm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for Passive Notables "Toxic Sludge" and "Dread Engineer's Concoction" via the following changes
trueas long as there are any negativeActionSpeedorMovementSpeedmods affecting the enemy (purposely only checked for enemies for now, as there are no relevant effects for players)SumNegativeValues()toModStoreas counter part toSumPositiveValues()Steps taken to verify a working solution:
TestDebuffs_spec.luaLink to a build that showcases this PR:
Before screenshot:
"against slowed enemies" node
"magnitude of ignite" node
After screenshot:
"against slowed enemies" node
"magnitude of ignite" node
