Fix calculation of Bifurcated Crits#2149
Merged
Merged
Conversation
The Bifurcated Crits calculation was incorrectly using the chance that a hit is a bifurcated crit to calculate the average crit damage increase instead of the chance that a crit is a bifurcated crit e.g. With 50% crit chance and having a Bifurcated Crit source 25% of the time will have no crit 50% of the time will have a regular crit 25% of the time will have a bifurcated crit but a 33% chance to have a bifurcated crit given that the hit is a crit already (25/75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Bifurcated Crits calculation was incorrectly using the chance that a hit is a bifurcated crit to calculate the average crit damage increase instead of the chance that a crit is a bifurcated crit
e.g. With 50% crit chance and having a Bifurcated Crit source
25% of the time will have no crit
50% of the time will have a regular crit
25% of the time will have a bifurcated crit
but a 33% chance to have a bifurcated crit given that the hit is a crit already (25/75)
We were using the 25% as the crit effect multi, instead of the 33%
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/l6fll0p0
Before screenshot:
After screenshot: