Fix sidebar percentage stat truncation#2152
Open
Divinicus1st wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar percentage stats using
%dcan display one point too low when the underlying value is a floating point number slightly below the expected integer, e.g.229.99999999999997displayed as229%.This changes affected sidebar percentage formats from
%d%%to%.0f%%so they round for display instead of truncating.Confirmed with a blank build taking only two
15% increased Critical Damage Bonusnodes (cf. screenshots):x2.30230%Crit Multiplier instead of229%Modified sidebar stats in
src/Modules/BuildDisplayStats.lua:Left resistance display unchanged, since there's a comment saying resistances are explicitly truncated in the calc output.
Before screenshot:
After screenshot: