Fix calculation of inverted Resistances when having a source of Penetration#2177
Merged
Conversation
The calculation for inverted res was handled incorrectly where it was applying an average reduction to the resistance value and then we were applying pen on top of that We now calculated the average res based on the chance to invert and the impact of pen
LocalIdentity
changed the title
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…athOfBuildingCommunity#2177) The calculation for inverted res was handled incorrectly where it was applying an average reduction to the resistance value and then we were applying pen on top of that We now calculated the average res based on the chance to invert and the impact of pen Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2133
Description of the problem being solved:
The calculation for inverted res was handled incorrectly, where it was applying an average reduction to the resistance value and then we were applying pen on top of that
We now calculated the average res based on the chance to invert and the impact of pen
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/w511ad0w
Before screenshot:
After screenshot: