Add required stats filter to trader#2290
Open
vaisest wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I considered adding a NOT section that would blacklist some mods from having weights generated, but I can't really see this being comfortable to use. There are very few things that actually need it in rare gear, and I think it's probably mostly just cull which we might as well manually blacklist. Megalomaniac have mods which inflate values for sure, but it would be quite uncomfortable to use. Manually editing the search and using price item is probably faster than doing the whole thing again, because it's likely you'll only realise it's giving you bad notables when you look at the results. It would also be more difficult to make a searchable list of the nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471.
Description of the problem being solved:
Adds a UI which can be used to add an AND filter to the query. There are quite a few old issues about this in the pob1 repo. This is especially useful for e.g. spirit, filling attributes, or corrupted blood jewels in poe1
This also fixes an issue where a row didn't get cleared when results were empty.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Path.space.of.space.Building-PoE2_2026-06-25_19-11-58.mp4