Fix Crit chance for Living Lightning and Caltrops#2302
Merged
Conversation
Both of these skills use a crit chance override which we were not taking into account unless you were dealing damage with an offhand weapon Now all skills that have a crit chance value on the skill, will override the crit chance of the weapon or minion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Both of these skills use a crit chance override which we were not taking into account unless you were dealing damage with an offhand weapon
Now all skills that have a crit chance value on the skill, will override the crit chance of the weapon or minion
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/7xcd9j0h
Before screenshot:
After screenshot: