Skip to content

Fix Crit chance for Living Lightning and Caltrops #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Jun 26, 2026
+6 −12
Merged

Fix Crit chance for Living Lightning and Caltrops #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Data/Skills/spectre.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6563,7 +6563,6 @@ skills["TBAbyssCarrionWingBeam"] = {
statDescriptionScope = "skill_stat_descriptions",
baseFlags = {
spell = true,
attack = true,
hit = true,
triggerable = true,
},
Expand Down Expand Up @@ -6721,7 +6720,6 @@ skills["TBVaalPyramidBeam"] = {
statDescriptionScope = "skill_stat_descriptions",
baseFlags = {
spell = true,
attack = true,
triggerable = true,
},
constantStats = {
Expand Down Expand Up @@ -7523,7 +7521,6 @@ skills["TBExcavatorSceptreErraticBeam"] = {
statDescriptionScope = "skill_stat_descriptions",
baseFlags = {
spell = true,
attack = true,
triggerable = true,
hit = true,
},
Expand Down
6 changes: 3 additions & 3 deletions src/Export/Skills/spectre.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@ statMap = {

#skill TBAbyssCarrionWingBeam Beam
#set TBAbyssCarrionWingBeam
#flags spell attack hit triggerable
#flags spell hit triggerable
#mods
#skillEnd

Expand All @@ -1028,7 +1028,7 @@ statMap = {

#skill TBVaalPyramidBeam Pyramid Beam
#set TBVaalPyramidBeam
#flags spell attack triggerable
#flags spell triggerable
#mods
#skillEnd

Expand Down Expand Up @@ -1143,7 +1143,7 @@ statMap = {

#skill TBExcavatorSceptreErraticBeam Beam
#set TBExcavatorSceptreErraticBeam
#flags spell attack triggerable hit
#flags spell triggerable hit
#mods
#skillEnd

Expand Down
9 changes: 3 additions & 6 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,9 +2386,6 @@ function calcs.offence(env, actor, activeSkill)
-- Unarmed override for Concoction skills
if skillFlags.unarmed then
source = copyTable(data.unarmedWeaponData[env.classId])
if skillData.CritChance then
source.CritChance = skillData.CritChance
end
end
if source.FacebreakerItemDamage and activeSkill.activeEffect.grantedEffect.weaponTypes and activeSkill.activeEffect.grantedEffect.weaponTypes["One Hand Mace"] then
for _, damageType in ipairs(dmgTypeList) do
Expand All @@ -2399,6 +2396,9 @@ function calcs.offence(env, actor, activeSkill)
if critOverride and source.type and source.type ~= "None" then
source.CritChance = critOverride
end
if skillData.CritChance then
source.CritChance = skillData.CritChance
end
t_insert(passList, {
label = "Main Hand",
source = source,
Expand All @@ -2416,9 +2416,6 @@ function calcs.offence(env, actor, activeSkill)
-- Unarmed override for Concoction skills
if skillFlags.unarmed then
source = copyTable(data.unarmedWeaponData[env.classId])
if skillData.CritChance then
source.CritChance = skillData.CritChance
end
end
if critOverride and source.type and source.type ~= "None" then
source.CritChance = critOverride
Expand Down
Loading