fix toggle saving and accounting for new item has any influence at all

Author: Peechey

src/Classes/ItemsTab.lua

@@ -1550,12 +1550,16 @@ local function copyAnointsAndEldritchImplicits(self, newItem)
 			end
 		end
 
+		-- if the new item is a Normal, Magic, or Rare Helmet, Body Armour, Gloves, or Boots and does not have any eldritch implicits nor any other influence
+		-- and your current respective item does, apply those implicits and influence to the new item
 		local implicitBaseTypes = { "Helmet", "Body Armour", "Gloves", "Boots" }
 		local implicitRarities = { "NORMAL", "MAGIC", "RARE" }
-		-- if the new item is a Normal, Magic, or Rare Helmet, Body Armour, Gloves, or Boots and does not have any eldritch implicits
-		-- and your current respective item does, apply those implicits and influence to the new item
-		if main.migrateEldritchImplicits and isValueInTable(implicitBaseTypes, newItem.base.type) and isValueInTable(implicitRarities, newItem.rarity) and
-				not (newItem.tangle and newItem.cleansing) and (currentItem.cleansing or currentItem.tangle) then
+		for _, influence in ipairs(itemLib.influenceInfo.default) do
+			if newItem[influence.key] then
+				return
+			end
+		end
+		if main.migrateEldritchImplicits and isValueInTable(implicitBaseTypes, newItem.base.type) and isValueInTable(implicitRarities, newItem.rarity) and (currentItem.cleansing or currentItem.tangle) then
 			local currentImplicits = currentItem.implicitModLines
 			if currentImplicits then
 				newItem.implicitModLines = currentImplicits

src/Modules/Main.lua

@@ -107,6 +107,7 @@ function main:Init()
 	self.dpiScaleOverridePercent = GetDPIScaleOverridePercent and GetDPIScaleOverridePercent() or 0
 	self.showWarnings = true
 	self.slotOnlyTooltips = true
+	self.migrateEldritchImplicits = true
 	self.notSupportedModTooltips = true
 	self.notSupportedTooltipText = " ^8(Not supported in PoB yet)"
 	self.POESESSID = ""
@@ -627,6 +628,9 @@ function main:LoadSettings(ignoreBuild)
 				if node.attrib.slotOnlyTooltips then
 					self.slotOnlyTooltips = node.attrib.slotOnlyTooltips == "true"
 				end
+				if node.attrib.migrateEldritchImplicits then
+					self.migrateEldritchImplicits = node.attrib.migrateEldritchImplicits == "true"
+				end
 				if node.attrib.notSupportedModTooltips then
 					self.notSupportedModTooltips = node.attrib.notSupportedModTooltips == "true"
 				end
@@ -761,6 +765,7 @@ function main:SaveSettings()
 		lastExportedWebsite = self.lastExportedWebsite,
 		showWarnings = tostring(self.showWarnings),
 		slotOnlyTooltips = tostring(self.slotOnlyTooltips),
+		migrateEldritchImplicits = tostring(self.migrateEldritchImplicits),
 		notSupportedModTooltips = tostring(self.notSupportedModTooltips),
 		POESESSID = self.POESESSID,
 		invertSliderScrollDirection = tostring(self.invertSliderScrollDirection),
@@ -1082,6 +1087,7 @@ function main:OpenOptionsPopup()
 	local initialDefaultItemAffixQuality = self.defaultItemAffixQuality or 0.5
 	local initialShowWarnings = self.showWarnings
 	local initialSlotOnlyTooltips = self.slotOnlyTooltips
+	local initialMigrateEldritchImplicits = self.migrateEldritchImplicits
 	local initialNotSupportedModTooltips = self.notSupportedModTooltips
 	local initialInvertSliderScrollDirection = self.invertSliderScrollDirection
 	local initialDisableDevAutoSave = self.disableDevAutoSave
@@ -1136,6 +1142,7 @@ function main:OpenOptionsPopup()
 		self.defaultItemAffixQuality = initialDefaultItemAffixQuality
 		self.showWarnings = initialShowWarnings
 		self.slotOnlyTooltips = initialSlotOnlyTooltips
+		self.migrateEldritchImplicits = initialMigrateEldritchImplicits
 		self.notSupportedModTooltips = initialNotSupportedModTooltips
 		self.invertSliderScrollDirection = initialInvertSliderScrollDirection
 		self.disableDevAutoSave = initialDisableDevAutoSave