Remove config and cache path

Removed the config as I don't see a reason for it to exists
The function was previously called on every frame in PassiveTreeView but is now cached after each tree change and that cache is used instead

Author: LocalIdentity

src/Classes/PassiveSpec.lua

@@ -81,6 +81,9 @@ function PassiveSpecClass:Init(treeVersion, convert)
 
 	-- Keys are node IDs, values are the replacement node
 	self.hashOverrides = { }
+
+	-- Cached highlight path for Split Personality jewels
+	self.splitPersonalityPath = { }
 end
 
 function PassiveSpecClass:Load(xml, dbFileName)
@@ -995,6 +998,22 @@ function PassiveSpecClass:GetShortestPathToClassStart(rootId)
 	return nil
 end
 
+function PassiveSpecClass:BuildSplitPersonalityPath()
+	local splitPersonalityPath = { }
+	for nodeId, itemId in pairs(self.jewels) do
+		local item = self.build.itemsTab.items[itemId]
+		if item and item.jewelData and item.jewelData.jewelIncEffectFromClassStart then
+			local path = self:GetShortestPathToClassStart(nodeId)
+			if path then
+				for id in pairs(path) do
+					splitPersonalityPath[id] = true
+				end
+			end
+		end
+	end
+	self.splitPersonalityPath = splitPersonalityPath
+end
+
 function PassiveSpecClass:AddMasteryEffectOptionsToNode(node)
 	node.sd = {}
 	if node.masteryEffects ~= nil and #node.masteryEffects > 0 then
@@ -1515,6 +1534,8 @@ function PassiveSpecClass:BuildAllDependsAndPaths()
 			end
 		end
 	end
+
+	self:BuildSplitPersonalityPath()
 end
 
 function PassiveSpecClass:ReplaceNode(old, newNode)

src/Classes/PassiveTreeView.lua

@@ -274,20 +274,7 @@ function PassiveTreeViewClass:Draw(build, viewPort, inputEvents)
 	end
 
 	-- Split Personality highlight
-	local splitPersonalityPath = { }
-	if main.showSplitPersonalityPath then
-		for nodeId, itemId in pairs(spec.jewels) do
-			local item = build.itemsTab.items[itemId]
-			if item and item.jewelData and item.jewelData.jewelIncEffectFromClassStart then
-				local path = spec:GetShortestPathToClassStart(nodeId)
-				if path then
-					for id in pairs(path) do
-						splitPersonalityPath[id] = true
-					end
-				end
-			end
-		end
-	end
+	local splitPersonalityPath = spec.splitPersonalityPath or { }
 
 	if treeClick == "LEFT" then
 		if hoverNode then

src/Modules/Main.lua

@@ -119,7 +119,6 @@ function main:Init()
 	self.showAnimations = true
 	self.showAllItemAffixes = true
 	self.errorReadingSettings = false
-	self.showSplitPersonalityPath = true
 
 	if not SetDPIScaleOverridePercent then SetDPIScaleOverridePercent = function(scale) end end
 
@@ -630,9 +629,6 @@ function main:LoadSettings(ignoreBuild)
 					self.dpiScaleOverridePercent = tonumber(node.attrib.dpiScaleOverridePercent) or 0
 					SetDPIScaleOverridePercent(self.dpiScaleOverridePercent)
 				end
-				if node.attrib.showSplitPersonalityPath then
-					self.showSplitPersonalityPath = node.attrib.showSplitPersonalityPath == "true"
-				end
 			end
 		end
 	end
@@ -765,7 +761,6 @@ function main:SaveSettings()
 		showAnimations = tostring(self.showAnimations),
 		showAllItemAffixes = tostring(self.showAllItemAffixes),
 		dpiScaleOverridePercent = tostring(self.dpiScaleOverridePercent),
-		showSplitPersonalityPath = tostring(self.showSplitPersonalityPath),
 	} })
 	local res, errMsg = common.xml.SaveXMLFile(setXML, self.userPath.."Settings.xml")
 	if not res then
@@ -1061,12 +1056,6 @@ function main:OpenOptionsPopup()
 	controls.invertSliderScrollDirection.tooltipText = "Default scroll direction is:\nScroll Up = Move right\nScroll Down = Move left"
 	controls.invertSliderScrollDirection.state = self.invertSliderScrollDirection
 
-	nextRow()
-	controls.showSplitPersonalityPath = new("CheckBoxControl", { "TOPLEFT", nil, "TOPLEFT" }, { defaultLabelPlacementX, currentY, 20 }, "^7Show Split Personality paths:", function(state)
-		self.showSplitPersonalityPath = state
-	end)
-	controls.showSplitPersonalityPath.state = self.showSplitPersonalityPath
-	
 	if launch.devMode then
 		nextRow()
 		controls.disableDevAutoSave = new("CheckBoxControl", { "TOPLEFT", nil, "TOPLEFT" }, { defaultLabelPlacementX, currentY, 20 }, "^7Disable Dev AutoSave:", function(state)
@@ -1107,7 +1096,6 @@ function main:OpenOptionsPopup()
 	local initialShowAnimations = self.showAnimations
 	local initialShowAllItemAffixes = self.showAllItemAffixes
 	local initialDpiScaleOverridePercent = self.dpiScaleOverridePercent
-	local initialShowSplitPersonalityPath = self.showSplitPersonalityPath
 
 	-- last line with buttons has more spacing
 	nextRow(1.5)
@@ -1166,7 +1154,6 @@ function main:OpenOptionsPopup()
 		self.showAllItemAffixes = initialShowAllItemAffixes
 		self.dpiScaleOverridePercent = initialDpiScaleOverridePercent
 		SetDPIScaleOverridePercent(self.dpiScaleOverridePercent)
-		self.showSplitPersonalityPath = initialShowSplitPersonalityPath
 		main:ClosePopup()
 	end)
 	nextRow(1.5)