fix quality tooltip to show quality lines that were previously on variant

Author: Peechey

src/Classes/SkillsTab.lua

@@ -756,16 +756,58 @@ function SkillsTabClass:CreateGemSlot(index)
 	end)
 	slot.quality.tooltipFunc = function(tooltip)
 		if tooltip:CheckForUpdate(self.build.outputRevision, self.displayGroup) then
-			if self.displayGroup.gemList[index] then
-				local calcFunc, calcBase = self.build.calcsTab:GetMiscCalculator(self.build)
-				if calcFunc then
-					local storedQuality = self.displayGroup.gemList[index].quality
-					self.displayGroup.gemList[index].quality = 20
-					local output = calcFunc()
-					self.displayGroup.gemList[index].quality = storedQuality
-					self.build:AddStatComparesToTooltip(tooltip, calcBase, output, "^7Setting to 20 quality will give you:")
+			-- Get the gem instance from the skills
+			local gemInstance = self.displayGroup.gemList[index]
+			if not gemInstance then
+				return
+			end
+			local gemData = gemInstance.gemData
+
+			-- Function for both granted effect and secondary such as vaal
+			local addQualityLines = function(qualityList, grantedEffect)
+				tooltip:AddLine(18, colorCodes.GEM..grantedEffect.name)
+				-- Hardcoded to use 20% quality instead of grabbing from gem, this is for consistency and so we always show something
+				tooltip:AddLine(16, colorCodes.NORMAL.."At +20% Quality:")
+				for k, qual in pairs(qualityList) do
+					-- Do the stats one at a time because we're not guaranteed to get the descriptions in the same order we look at them here
+					local stats = { }
+					stats[qual[1]] = qual[2] * 20
+					local descriptions = self.build.data.describeStats(stats, grantedEffect.statDescriptionScope)
+					-- line may be nil if the value results in no line due to not being enough quality
+					for _, line in ipairs(descriptions) do
+						if line then
+							-- Check if we have a handler for the mod in the gem's statMap or in the shared stat map for skills
+							if grantedEffect.statMap[qual[1]] or self.build.data.skillStatMap[qual[1]] then
+								tooltip:AddLine(16, colorCodes.MAGIC..line)
+							else
+								local line = colorCodes.UNSUPPORTED..line
+								line = main.notSupportedModTooltips and (line .. main.notSupportedTooltipText) or line
+								tooltip:AddLine(16, line)
+							end
+						end
+					end
 				end
 			end
+			-- Check if there is a quality of this type for the effect
+			if gemData and gemData.grantedEffect.qualityStats and gemData.grantedEffect.qualityStats["Default"] then
+				local qualityTable = gemData.grantedEffect.qualityStats["Default"]
+				addQualityLines(qualityTable, gemData.grantedEffect)
+				tooltip:AddSeparator(10)
+			end
+			if gemData and gemData.secondaryGrantedEffect and gemData.secondaryGrantedEffect.qualityStats and gemData.secondaryGrantedEffect.qualityStats["Default"] then
+				local qualityTable = gemData.secondaryGrantedEffect.qualityStats["Default"]
+				addQualityLines(qualityTable, gemData.secondaryGrantedEffect)
+				tooltip:AddSeparator(10)
+			end
+
+			local calcFunc, calcBase = self.build.calcsTab:GetMiscCalculator(self.build)
+			if calcFunc then
+				local storedQuality = self.displayGroup.gemList[index].quality
+				self.displayGroup.gemList[index].quality = 20
+				local output = calcFunc()
+				self.displayGroup.gemList[index].quality = storedQuality
+				self.build:AddStatComparesToTooltip(tooltip, calcBase, output, "^7Setting to 20 quality will give you:")
+			end
 		end
 	end
 	slot.quality:AddToTabGroup(self.controls.groupLabel)