Skip to content

Commit 4136feb

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Tinctures applying their effects even when you have no Mana (#9769)
Tinctures need stacks of mana burn in order to keep their effect active If you are using a build with Blood Magic or have 100% Mana reserved then you cannot have any Tincture effects active unless you have Weeping Wounds Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent a392b94 commit 4136feb

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

src/Modules/CalcPerform.lua

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1703,6 +1703,11 @@ function calcs.perform(env, skipEHP)
17031703

17041704

17051705
local function mergeTinctures(tinctures)
1706+
local tincturesNotInflictManaBurn = m_min(modDB:Sum("BASE", nil, "TincturesNotInflictManaBurn"), 100)
1707+
local canGainRequiredBurn = modDB:Flag(nil, "Condition:WeepingWoundsInsteadOfManaBurn") or (tincturesNotInflictManaBurn < 100 and (output.ManaUnreserved or 0) > 0)
1708+
if not canGainRequiredBurn then
1709+
return
1710+
end
17061711
local tinctureBuffs = { }
17071712
local tinctureConditions = {}
17081713
local tinctureBuffsPerBase = {}
@@ -1773,7 +1778,6 @@ function calcs.perform(env, skipEHP)
17731778
-- This needs to be done in 2 steps to account for effects affecting life recovery from flasks
17741779
-- For example Sorrow of the Divine and buffs (like flask recovery watchers eye)
17751780
mergeFlasks(env.flasks, false, true)
1776-
mergeTinctures(env.tinctures)
17771781

17781782
-- Merge keystones again to catch any that were added by flasks
17791783
modLib.mergeKeystones(env, env.modDB)
@@ -1921,6 +1925,10 @@ function calcs.perform(env, skipEHP)
19211925
-- Set the life/mana reservations (hold off on GrantReserved"..pool.."AsAura)
19221926
doActorLifeManaReservation(env.player, not modDB:Flag(nil, "ManaIncreasedByOvercappedLightningRes"))
19231927

1928+
if env.mode_combat then
1929+
mergeTinctures(env.tinctures)
1930+
end
1931+
19241932
-- Process attribute requirements
19251933
do
19261934
local reqMult = calcLib.mod(modDB, nil, "GlobalAttributeRequirements")

0 commit comments

Comments
 (0)