Require self to be supplied to parent constructors manually (using :) to fix type checking

Author: vaisest

.gitignore

@@ -18,6 +18,7 @@ luajit/
 spec/test_results.log
 spec/test_generation.log
 src/luacov.stats.out
+runtime/lua/debugger.lua
 
 # Release
 manifest-updated.xml

src/Classes/BuildListControl.lua

@@ -10,7 +10,7 @@ local s_format = string.format
 local BuildListClass = newClass("BuildListControl", "ListControl")
 
 function BuildListClass:BuildListControl(anchor, rect, listMode)
-	self.ListControl(anchor, rect, 20, "VERTICAL", false, listMode.list)
+	self:ListControl(anchor, rect, 20, "VERTICAL", false, listMode.list)
 	self.listMode = listMode
 	self.colList = {
 		{ width = function() return self:GetProperty("width") - 172 end },

src/Classes/ButtonControl.lua

@@ -7,8 +7,8 @@
 local ButtonClass = newClass("ButtonControl", "Control", "TooltipHost")
 
 function ButtonClass:ButtonControl(anchor, rect, label, onClick, onHover, forceTooltip)
-	self.Control(anchor, rect)
-	self.TooltipHost()
+	self:Control(anchor, rect)
+	self:TooltipHost()
 	self.label = label
 	self.onClick = onClick
 	self.onHover = onHover

src/Classes/CalcBreakdownControl.lua

@@ -17,8 +17,8 @@ local band = bit.band
 local CalcBreakdownClass = newClass("CalcBreakdownControl", "Control", "ControlHost")
 
 function CalcBreakdownClass:CalcBreakdownControl(calcsTab)
-	self.Control()
-	self.ControlHost()
+	self:Control()
+	self:ControlHost()
 	self.calcsTab = calcsTab
 	self.shown = false
 	self.tooltip = new("Tooltip")

src/Classes/CalcSectionControl.lua

@@ -9,8 +9,8 @@ local t_insert = table.insert
 local CalcSectionClass = newClass("CalcSectionControl", "Control", "ControlHost")
 
 function CalcSectionClass:CalcSectionControl(calcsTab, width, id, group, colour, subSection, updateFunc)
-	self.Control(calcsTab, {0, 0, width, 0})
-	self.ControlHost()
+	self:Control(calcsTab, {0, 0, width, 0})
+	self:ControlHost()
 	self.calcsTab = calcsTab
 	self.id = id
 	self.group = group

src/Classes/CalcsTab.lua

@@ -21,9 +21,9 @@ local CalcsTabClass = newClass("CalcsTab", "UndoHandler", "ControlHost", "Contro
 
 ---@param build Build
 function CalcsTabClass:CalcsTab(build)
-	self.UndoHandler()
-	self.ControlHost()
-	self.Control()
+	self:UndoHandler()
+	self:ControlHost()
+	self:Control()
 
 	self.build = build
 

src/Classes/CheckBoxControl.lua

@@ -8,8 +8,8 @@ local CheckBoxClass = newClass("CheckBoxControl", "Control", "TooltipHost")
 
 function CheckBoxClass:CheckBoxControl(anchor, rect, label, changeFunc, tooltipText, initialState)
 	rect[4] = rect[3] or 0
-	self.Control(anchor, rect)
-	self.TooltipHost(tooltipText)
+	self:Control(anchor, rect)
+	self:TooltipHost(tooltipText)
 	self.label = label
 	self.labelWidth = DrawStringWidth(self.width - 4, "VAR", label or "") + 5
 	self.changeFunc = changeFunc

src/Classes/CompareEntry.lua

@@ -13,7 +13,7 @@ local m_max = math.max
 local CompareEntryClass = newClass("CompareEntry", "ControlHost")
 
 function CompareEntryClass:CompareEntry(xmlText, label)
-	self.ControlHost()
+	self:ControlHost()
 
 	self.label = label or "Comparison Build"
 	self.buildName = label or "Comparison Build"

src/Classes/ComparePowerReportListControl.lua

@@ -11,7 +11,7 @@ local t_sort = table.sort
 local ComparePowerReportListClass = newClass("ComparePowerReportListControl", "ListControl")
 
 function ComparePowerReportListClass:ComparePowerReportListControl(anchor, rect)
-	self.ListControl(anchor, rect, 18, "VERTICAL", false)
+	self:ListControl(anchor, rect, 18, "VERTICAL", false)
 
 	local width = rect[3]
 	self.impactColumn = { width = width * 0.22, label = "", sortable = true }

src/Classes/CompareTab.lua

@@ -127,8 +127,8 @@ local CompareTabClass = newClass("CompareTab", "ControlHost", "Control")
 
 ---@param build Build
 function CompareTabClass:CompareTab(primaryBuild)
-	self.ControlHost()
-	self.Control()
+	self:ControlHost()
+	self:Control()
 
 	self.primaryBuild = primaryBuild