FIX: Autoexertion not using active skill cooldown. Misc cleanup. (#8801)

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>

Author: Paliak

src/Data/SkillStatMap.lua

@@ -236,7 +236,7 @@ return {
 	skill("triggeredByAutomation", nil, { type = "SkillType", skillTypeList = {SkillType.Triggerable, SkillType.Spell, SkillType.Instant} }),
 },
 ["support_autocast_warcries"] = {
-	skill("triggeredByAutoCry", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Warcry }),
+	skill("triggeredByAutoexertion", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Warcry }),
 },
 ["cast_on_stunned_%"] = {
 	skill("chanceToTriggerOnStun", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Spell }),

src/Data/Skills/act_str.lua

@@ -731,9 +731,6 @@ skills["SupportAutoexertion"] = {
 			mod("BaseManaCostOverride", "OVERRIDE", nil),
 		},
 	},
-	baseMods = {
-		skill("SupportedByAutoexertion", true),
-	},
 	qualityStats = {
 		Default = {
 			{ "base_cooldown_speed_+%", 0.5 },

src/Export/Skills/act_str.txt

@@ -135,9 +135,6 @@ local skills, mod, flag, skill = ...
 			mod("BaseManaCostOverride", "OVERRIDE", nil),
 		},
 	},
-	baseMods = {
-		skill("SupportedByAutoexertion", true),
-	},
 #mods
 
 #skill BattlemagesCry

src/Modules/CalcOffence.lua

@@ -282,7 +282,7 @@ local function calcWarcryCastTime(skillModList, skillCfg, skillData, actor)
 	local warcryCastTime = baseSpeed * calcLib.mod(skillModList, skillCfg, "WarcrySpeed") * calcs.actionSpeedMod(actor)
 	warcryCastTime = m_min(warcryCastTime, data.misc.ServerTickRate)
 	warcryCastTime = 1 / warcryCastTime
-	if skillModList:Flag(skillCfg, "InstantWarcry") or skillData.SupportedByAutoexertion then
+	if skillModList:Flag(skillCfg, "InstantWarcry") or skillData.triggeredByAutoexertion then
 		warcryCastTime = 0
 	end
 	return warcryCastTime

src/Modules/CalcTriggers.lua

@@ -1169,7 +1169,7 @@ local configTable = {
 					return isWandAttack and not skill.skillData.triggeredBySpellSlinger
 				end}
 	end,
-	["call to arms"] = function(env)
+	["call to arms"] = function(env) -- This is for backwards compatibility only
 		if env.player.mainSkill.activeEffect.grantedEffect.name == "Call to Arms" then
 			env.player.mainSkill.skillFlags.globalTrigger = true
 			env.player.mainSkill.skillFlags.skipEffectiveRate = true
@@ -1208,8 +1208,12 @@ local configTable = {
 			env.player.mainSkill.skillFlags.globalTrigger = true
 			env.player.mainSkill.skillFlags.skipEffectiveRate = true
 		else -- Needed to get the cooldown form the active part
+			-- Autoexertion has cooldown as part of its support part
+			-- Not really sure which one should apply here
+			-- Applying the one form the active part to be consistant
+			-- with skills like Automation and Spellslinger
 			for _, skill in ipairs(env.player.activeSkillList) do
-				if skill.activeEffect.grantedEffect.name == "Automation" then
+				if skill.activeEffect.grantedEffect.name == "Autoexertion" then
 					env.player.mainSkill.triggeredBy.grantedEffect = skill.activeEffect.grantedEffect
 					break
 				end