Skip to content

Commit 5318f15

Browse files
author
LocalIdentity
committed
Fix some buffs applying incorrectly to the player
PR #9676 added code to allow the support gem to grant a global effect but this had the effect of scaling other global effects by the number of skills in the build and was ignoring their effect conditions e.g. Ancient Skull 50% inc damage was applying 20 times to player skills in a build
1 parent f23adba commit 5318f15

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/Data/Skills/sup_str.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2838,7 +2838,7 @@ skills["SupportHallow"] = {
28382838
mod("HallowingFlameMagnitude", "INC", nil)
28392839
},
28402840
["support_hallow_inflict_hallowing_flame_on_melee_hit"] = {
2841-
flag("Condition:CanInflictHallowingFlame", { type = "GlobalEffect", effectType = "Global" })
2841+
flag("Condition:CanInflictHallowingFlame", { type = "GlobalEffect", effectType = "GlobalDB" })
28422842
}
28432843
},
28442844
qualityStats = {

src/Export/Skills/sup_str.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ local skills, mod, flag, skill = ...
425425
mod("HallowingFlameMagnitude", "INC", nil)
426426
},
427427
["support_hallow_inflict_hallowing_flame_on_melee_hit"] = {
428-
flag("Condition:CanInflictHallowingFlame", { type = "GlobalEffect", effectType = "Global" })
428+
flag("Condition:CanInflictHallowingFlame", { type = "GlobalEffect", effectType = "GlobalDB" })
429429
}
430430
},
431431
#mods

src/Modules/CalcPerform.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2147,7 +2147,7 @@ function calcs.perform(env, skipEHP)
21472147
-- Nothing!
21482148
elseif buff.enemyCond and not enemyDB:GetCondition(buff.enemyCond) then
21492149
-- Also nothing :/
2150-
elseif buff.type == "Global" then
2150+
elseif buff.type == "GlobalDB" then
21512151
modDB:AddList(buff.modList) -- Allows a skill mod to affect other skills through modDB
21522152
elseif buff.type == "Buff" and not skillModList:Flag(skillCfg, "DisableBuff") then
21532153
if env.mode_buffs and (not activeSkill.skillFlags.totem or buff.allowTotemBuff) then

0 commit comments

Comments
 (0)