Merge remote-tracking branch 'fork/dev' into add_league_information_to_save_xmls_for_imported_characters

Author: Wires77

.busted

@@ -1,6 +1,6 @@
 return {
     _all = {
-        coverage = true,
+        coverage = false,
         verbose = true,
     },
     default = {

.editorconfig

@@ -0,0 +1,4 @@
+[*.lua]
+trim_trailing_whitespace = false
+indent_style = tab
+max_line_length = 120

.gitattributes

@@ -61,3 +61,9 @@
 #*.PDF   diff=astextplain
 #*.rtf   diff=astextplain
 #*.RTF   diff=astextplain
+
+###############################################################################
+# Executable files - preserve execution permissions on Unix systems
+# (https://git-scm.com/docs/gitattributes#_executable)
+###############################################################################
+runtime/*.exe binary

.github/ISSUE_TEMPLATE/accuracy_bug_report.yaml

@@ -1,12 +1,13 @@
 name: Accuracy bug report
-description: Create a bug report to help us fix incorrect wordings
-labels: ["bug:accuracy"]
+description: Create a bug report to help us fix incorrect wording in Path of Building for PoE1.
+labels: ["bug: accuracy"]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for reporting an issue.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for reporting an issue with PoB-**PoE1**.  
+        [Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: version
     attributes:
@@ -19,15 +20,27 @@ body:
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: expected
     attributes:
-      label: What is the wording ingame?
+      label: What is the wording in-game?
       description: Please write a clear and concise description of what should happen.
       placeholder: |
-        E.g. when I look at the unique [...] ingame it says [...].
+        E.g. when I look at the unique [...] in-game it says [...].
         [screenshot].
     validations:
       required: true
@@ -44,9 +57,9 @@ body:
   - type: textarea
     id: build_code
     attributes:
-      label: Character build code
+      label: PoB for PoE1 build code
       description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
-      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
+      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
       render: shell
     validations:
       required: false

.github/ISSUE_TEMPLATE/application_bug_report.yaml

@@ -1,12 +1,13 @@
 name: Application bug report
-description: Create a bug report to help us fix an issue in Path of Building
+description: Create a bug report to help us fix an issue in Path of Building for PoE1.
 labels: [bug]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for reporting an issue.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for reporting an issue with PoB-**PoE1**.
+        [Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: version
     attributes:
@@ -19,8 +20,20 @@ body:
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: expected
     attributes:
@@ -53,9 +66,9 @@ body:
   - type: textarea
     id: build_code
     attributes:
-      label: Character build code
+      label: PoB for PoE1 build code
       description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
-      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
+      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
       render: shell
     validations:
       required: false

.github/ISSUE_TEMPLATE/behaviour_bug_report.yaml

@@ -1,12 +1,13 @@
 name: Behaviour bug report
-description: Create a bug report to help us fix incorrect behaviour or logic
-labels: ["bug:behaviour"]
+description: Create a bug report to help us fix incorrect behaviour or logic in Path of Building for PoE1.
+labels: ["bug: behaviour"]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for reporting an issue.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for reporting an issue with PoB-**PoE1**.
+        [Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: version
     attributes:
@@ -19,7 +20,7 @@ body:
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
   - type: checkboxes
     id: validity
@@ -28,12 +29,24 @@ body:
       options: 
         - label: I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: expected
     attributes:
-      label: What is the behaviour ingame?
+      label: What is the behaviour in-game?
       description: Please write a clear and concise description of what should happen.
-      placeholder: E.g. Ingame something behaves in a certain way. e.g. curse priority, auras disabled by mod, skills triggered in a certain way, etc.
+      placeholder: E.g. In-game something behaves in a certain way. e.g. curse priority, auras disabled by mod, skills triggered in a certain way, etc.
     validations:
       required: true
   - type: textarea
@@ -59,9 +72,9 @@ body:
   - type: textarea
     id: build_code
     attributes:
-      label: Character build code
+      label: PoB for PoE1 build code
       description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
-      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
+      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
       render: shell
     validations:
       required: true

.github/ISSUE_TEMPLATE/calculation_bug_report.yaml

@@ -1,12 +1,13 @@
 name: Calculation bug report
-description: Create a bug report to help us fix incorrect calculations
-labels: ["bug:calculation"]
+description: Create a bug report to help us fix incorrect calculations in Path of Building for PoE1.
+labels: ["bug: calculation"]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for reporting an issue.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for reporting an issue with PoB-**PoE1**.  
+        [Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: version
     attributes:
@@ -19,7 +20,7 @@ body:
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
   - type: checkboxes
     id: validity
@@ -28,12 +29,24 @@ body:
       options:
         - label: I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: expected
     attributes:
-      label: What is the value from the calculation ingame?
+      label: What is the value from the calculation in-game?
       description: Please write a clear and concise description of what should happen.
-      placeholder: E.g. Ingame when I [...] and use [...] I believe it should be calculated as [...] and so the value is [...].
+      placeholder: E.g. In-game when I [...] and use [...] I believe it should be calculated as [...] and so the value is [...].
     validations:
       required: true
   - type: textarea
@@ -59,9 +72,9 @@ body:
   - type: textarea
     id: build_code
     attributes:
-      label: Character build code
+      label: PoB for PoE1 build code
       description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
-      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
+      placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
       render: shell
     validations:
       required: true

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: false

.github/ISSUE_TEMPLATE/crash_report.yaml

@@ -1,12 +1,13 @@
 name: Crash report
-description: Create a crash report to help us fix critical issues
+description: Create a crash report to help us fix critical issues in Path of Building for PoE1.
 labels: [bug, crash]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for reporting a crash or serve graphical issue.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for reporting a crash or severe graphical issue in PoB-**PoE1**.
+        [Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: version
     attributes:
@@ -19,8 +20,20 @@ body:
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: context
     attributes:
@@ -58,10 +71,10 @@ body:
   - type: textarea
     id: build_code
     attributes:
-      label: Character build code
+      label: PoB for PoE1 build code
       description: Provide a build code if the crash/graphical issue is caused by a certain build.
       placeholder: |
-        This can be either a code copied from the "Import/Export Build" tab or a link to a shared build. 
+        This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build. 
         In the case where Path of Building crashes/doesn't work on startup or when you open a build.
         Go to your builds folder (default %userprofile%/Documents/Path of Building/Builds) and copy the problematic build's .xml contents into a pastebin and supply the link.
       render: shell

.github/ISSUE_TEMPLATE/feature_request.yaml

@@ -1,19 +1,32 @@
 name: Feature request
-description: Suggest an idea for this project
+description: Suggest an idea for Path of Building for PoE1.
 labels: [enhancement]
 body:
   - type: markdown
     attributes:
       value: |
-        Thank you for suggesting a feature.
-        Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
+        Thank you for suggesting a feature for PoB-**PoE1**.
+        [Feature requests for PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
+        Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
   - type: checkboxes
     id: duplicates
     attributes:
       label: Check for duplicates
       options:
-        - label: I've checked for duplicate issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues)
+        - label: I've checked for duplicate open **and closed** issues by using the search function of the [issue tracker](https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues?q=is%3Aissue)
           required: true
+  - type: dropdown
+    id: platform
+    attributes:
+      label: What platform are you running Path of Building on?
+      options: 
+        - Windows
+        - Linux - Wine
+        - Linux - PoB Frontend
+        - MacOS
+      default: 0
+    validations:
+      required: true
   - type: textarea
     id: problem
     attributes: