Skip to content

Commit 6f67da4

Browse files
author
LocalIdentity
committed
Fix Consecrated Ground effect not scaling Accuracy from Shining Justice
Consecrated ground effect is meant to scale the accuracy gained from the new Shining Justice node
1 parent 6a5c80f commit 6f67da4

3 files changed

Lines changed: 10 additions & 17 deletions

File tree

src/Data/ModCache.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8161,7 +8161,7 @@ c["Consecrated Ground you create applies 10% increased Damage taken to Enemies"]
81618161
c["Consecrated Ground you create applies 15% increased Damage taken to Enemies"]={{[1]={flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=15}}}},nil}
81628162
c["Consecrated Ground you create causes Life Regeneration to"]={nil,"Consecrated Ground you create causes Life Regeneration to "}
81638163
c["Consecrated Ground you create causes Life Regeneration to also Recover Energy Shield for you and Allies"]={{[1]={flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="LifeRegenerationRecoversEnergyShield",type="FLAG",value=true}}}},nil}
8164-
c["Consecrated Ground you create grants 30% increased Accuracy Rating to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="Accuracy",type="INC",value=30}}}},nil}
8164+
c["Consecrated Ground you create grants 30% increased Accuracy Rating to you and Allies"]={{[1]={flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ConsecratedGroundAlsoAccuracy",type="INC",value=30}}}},nil}
81658165
c["Consecrated Ground you create grants 30% increased Mana Regeneration"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ManaRegen",type="INC",value=30}},nil}
81668166
c["Consecrated Ground you create while affected by Zealotry causes enemies to take 10% increased Damage"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="OnConsecratedGround"},[2]={type="Condition",var="AffectedByZealotry"},flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=10}}}},nil}
81678167
c["Consumes Frenzy Charges on use"]={nil,"Consumes Frenzy Charges on use "}

src/Modules/CalcPerform.lua

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -740,6 +740,13 @@ local function doActorMisc(env, actor)
740740
modDB:NewMod("Speed", "INC", 20, "Her Embrace", ModFlag.Cast)
741741
modDB:NewMod("MovementSpeed", "INC", 20, "Her Embrace")
742742
end
743+
if modDB:Flag(nil, "Condition:OnConsecratedGround") then
744+
local effect = 1 + modDB:Sum("INC", nil, "ConsecratedGroundEffect") / 100
745+
modDB:NewMod("LifeRegenPercent", "BASE", 5 * effect, "Consecrated Ground")
746+
modDB:NewMod("CurseEffectOnSelf", "INC", -50 * effect, "Consecrated Ground")
747+
modDB:NewMod("Accuracy", "INC", m_floor(modDB:Sum("INC", nil, "ConsecratedGroundAlsoAccuracy") * effect), "Consecrated Ground")
748+
enemyDB:NewMod("DamageTaken", "INC", m_floor(enemyDB:Sum("INC", nil, "DamageTakenConsecratedGround") * effect), "Consecrated Ground")
749+
end
743750
if modDB:Flag(nil, "Condition:PhantasmalMight") then
744751
modDB.multipliers["BuffOnSelf"] = (modDB.multipliers["BuffOnSelf"] or 0) + (output.ActivePhantasmLimit or 1) - 1 -- slight hack to not double count the initial buff
745752
end
@@ -1960,13 +1967,6 @@ function calcs.perform(env, skipEHP)
19601967
end
19611968
end
19621969

1963-
-- Deal with Consecrated Ground
1964-
if modDB:Flag(nil, "Condition:OnConsecratedGround") then
1965-
local effect = 1 + modDB:Sum("INC", nil, "ConsecratedGroundEffect") / 100
1966-
modDB:NewMod("LifeRegenPercent", "BASE", 5 * effect, "Consecrated Ground")
1967-
modDB:NewMod("CurseEffectOnSelf", "INC", -50 * effect, "Consecrated Ground")
1968-
end
1969-
19701970
if modDB:Flag(nil, "ManaAppliesToShockEffect") then
19711971
-- Maximum Mana conversion from Lightning Mastery
19721972
local multiplier = (modDB:Max(nil, "ImprovedManaAppliesToShockEffect") or 100) / 100
@@ -3397,12 +3397,6 @@ function calcs.perform(env, skipEHP)
33973397
end
33983398
end
33993399

3400-
-- Handle consecrated ground effects on enemies
3401-
if enemyDB:Flag(nil, "Condition:OnConsecratedGround") then
3402-
local effect = 1 + modDB:Sum("INC", nil, "ConsecratedGroundEffect") / 100
3403-
enemyDB:NewMod("DamageTaken", "INC", enemyDB:Sum("INC", nil, "DamageTakenConsecratedGround") * effect, "Consecrated Ground")
3404-
end
3405-
34063400
-- Defence/offence calculations
34073401
calcs.defence(env, env.player)
34083402
if not skipEHP then

src/Modules/ModParser.lua

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3931,6 +3931,8 @@ local specialModList = {
39313931
["your maximum endurance charges is equal to your maximum frenzy charges"] = { flag("MaximumEnduranceChargesIsMaximumFrenzyCharges") },
39323932
["your maximum frenzy charges is equal to your maximum power charges"] = { flag("MaximumFrenzyChargesIsMaximumPowerCharges") },
39333933
["your curse limit is equal to your maximum power charges"] = { flag("CurseLimitIsMaximumPowerCharges") },
3934+
["consecrated ground you create grants (%d+)%% increased accuracy rating to you and allies"] = function(num) return { mod("ExtraAura", "LIST", { mod = mod("ConsecratedGroundAlsoAccuracy", "INC", num, { type = "Condition", var = "OnConsecratedGround" }) }) } end,
3935+
["consecrated ground created during effect applies (%d+)%% increased damage taken to enemies"] = function(num) return { mod("EnemyModifier", "LIST", { mod = mod("DamageTakenConsecratedGround", "INC", num, { type = "Condition", var = "OnConsecratedGround" }) }, { type = "Condition", var = "UsingFlask" }) } end,
39343936
["consecrated ground you create while affected by zealotry causes enemies to take (%d+)%% increased damage"] = function(num) return { mod("EnemyModifier", "LIST", { mod = mod("DamageTakenConsecratedGround", "INC", num) }, { type = "ActorCondition", actor = "enemy", var = "OnConsecratedGround" }, { type = "Condition", var = "AffectedByZealotry" }) } end,
39353937
["if you've warcried recently, you and nearby allies have (%d+)%% increased attack, cast and movement speed"] = function(num) return {
39363938
mod("ExtraAura", "LIST", { mod = mod("Speed", "INC", num) }, { type = "Condition", var = "UsedWarcryRecently" }),
@@ -4879,9 +4881,6 @@ local specialModList = {
48794881
["when hit during effect, (%d+)%% of life loss from damage taken occurs over 4 seconds instead"] = function(num) return { mod("LifeLossPrevented", "BASE", num, { type = "Condition", var = "UsingFlask" }) } end,
48804882
["y?o?u?r? ?skills [ch][oa][sv][te] no mana c?o?s?t? ?during f?l?a?s?k? ?effect"] = { mod("ManaCost", "MORE", -100, { type = "Condition", var = "UsingFlask" }) },
48814883
["life recovery from flasks also applies to energy shield during f?l?a?s?k? ?effect"] = { flag("LifeFlaskAppliesToEnergyShield", { type = "Condition", var = "UsingFlask" }) },
4882-
["consecrated ground created during effect applies (%d+)%% increased damage taken to enemies"] = function(num) return {
4883-
mod("EnemyModifier", "LIST", { mod = mod("DamageTakenConsecratedGround", "INC", num, { type = "Condition", var = "OnConsecratedGround" }) }, { type = "Condition", var = "UsingFlask" })
4884-
} end,
48854884
["profane ground you create inflicts malediction on enemies"] = { mod("EnemyModifier", "LIST", { mod = flag("HasMalediction", { type = "Condition", var = "OnProfaneGround" }) }) },
48864885
["profane ground you create also affects you and your allies, granting chaotic might"] = { mod("ExtraAura", "LIST", { mod = flag("Condition:ChaoticMight", { type = "Condition", var = "OnProfaneGround" }) }) },
48874886
["raised beast spectres have farrul's farric presence"] = {

0 commit comments

Comments
 (0)