Skip to content

Commit 842eab6

Browse files
committed
Fix tests
1 parent f6480b3 commit 842eab6

2 files changed

Lines changed: 17 additions & 17 deletions

File tree

spec/System/TestItemParse_spec.lua

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -393,9 +393,9 @@ describe("TestItemParse", function()
393393
end)
394394

395395
it("unscalable", function()
396-
local item = new("Item", raw("{unscalable}+8 to Strength"))
396+
local item = new("Item"):Item(raw("{unscalable}+8 to Strength"))
397397
assert.truthy(item.explicitModLines[1].unscalable)
398-
item = new("Item", raw("+8 to Strength - Unscalable Value"))
398+
item = new("Item"):Item(raw("+8 to Strength - Unscalable Value"))
399399
assert.truthy(item.explicitModLines[1].unscalable)
400400
end)
401401

@@ -480,22 +480,22 @@ describe("TestAdvancedItemParse #item", function()
480480
end
481481

482482
it("parses to craft", function()
483-
local item = new("Item", raw([[
483+
local item = new("Item"):Item(raw([[
484484
{ Prefix Modifier "Fecund" (Tier: 1) — Life }
485485
+142(130-144) to maximum Life
486486
]], "Cord Belt"))
487487
assert.are.equals("IncreasedLife9", item.prefixes[1].modId)
488488
assert.are.equals(0.857, item.prefixes[1].range)
489489
assert.are.equals("life", item.explicitModLines[1].modTags[1])
490-
item = new("Item", raw([[
490+
item = new("Item"):Item(raw([[
491491
{ Master Crafted Suffix Modifier "of Craft" (Rank: 3) — Elemental, Cold, Resistance }
492492
+35(29-35)% to Cold Resistance
493493
]], "Cord Belt"))
494494
assert.truthy(item.explicitModLines[1].crafted)
495495
end)
496496

497497
it("parses correct range", function()
498-
local item = new("Item", raw([[
498+
local item = new("Item"):Item(raw([[
499499
{ Prefix Modifier "Freezing" (Tier: 5) — Damage, Elemental, Cold, Caster — 8% Increased }
500500
Adds 17(16-20) to 35(30-36) Cold Damage to Spells
501501
]], "Void Sceptre"))
@@ -504,7 +504,7 @@ describe("TestAdvancedItemParse #item", function()
504504

505505
-- GGG scales each mod line separately here, but PoB scales them both together, so this parsing is a bit wonky
506506
it("parses multi-line mod", function()
507-
local item = new("Item", raw([[
507+
local item = new("Item"):Item(raw([[
508508
{ Prefix Modifier "Warlock's" (Tier: 4) — Mana, Damage, Caster }
509509
32(30-37)% increased Spell Damage
510510
+46(42-47) to maximum Mana
@@ -515,7 +515,7 @@ describe("TestAdvancedItemParse #item", function()
515515
end)
516516

517517
it("resets linePrefix", function()
518-
local item = new("Item", raw([[
518+
local item = new("Item"):Item(raw([[
519519
{ Prefix Modifier "Warlock's" (Tier: 4) — Mana, Damage, Caster }
520520
32(30-37)% increased Spell Damage
521521
+46(42-47) to maximum Mana
@@ -526,7 +526,7 @@ describe("TestAdvancedItemParse #item", function()
526526
end)
527527

528528
it("resets linePostfix", function()
529-
local item = new("Item", raw([[
529+
local item = new("Item"):Item(raw([[
530530
{ Corruption Enhancement — Mana }
531531
24(20-30)% increased Mana Regeneration Rate
532532
--------
@@ -536,7 +536,7 @@ describe("TestAdvancedItemParse #item", function()
536536
end)
537537

538538
it("parses vaaled catalyst", function()
539-
local item = new("Item", raw([[
539+
local item = new("Item"):Item(raw([[
540540
Quality (Attribute Modifiers): +19% (augmented)
541541
{ Unique Modifier — Attribute — 19% Increased }
542542
+120(80-100) to all Attributes
@@ -549,7 +549,7 @@ describe("TestAdvancedItemParse #item", function()
549549
end)
550550

551551
it("parses vaaled catalyst within range", function()
552-
local item = new("Item", raw([[
552+
local item = new("Item"):Item(raw([[
553553
Quality (Attribute Modifiers): +19% (augmented)
554554
{ Unique Modifier — Attribute — 19% Increased }
555555
+95(80-100) to all Attributes
@@ -562,7 +562,7 @@ describe("TestAdvancedItemParse #item", function()
562562
end)
563563

564564
it("doesn't scale unscalable", function()
565-
local item = new("Item", raw([[
565+
local item = new("Item"):Item(raw([[
566566
Quality (Life and Mana Modifiers): +20% (augmented)
567567
{ Unique Modifier — Life, Defences, Energy Shield, Minion, Gem }
568568
Socketed Golem Skills gain 20% of Maximum Life as Extra Maximum Energy Shield — Unscalable Value
@@ -571,7 +571,7 @@ describe("TestAdvancedItemParse #item", function()
571571
end)
572572

573573
it("correctly matches conqueror mod", function()
574-
local item = new("Item", raw([[
574+
local item = new("Item"):Item(raw([[
575575
{ Suffix Modifier "of the Conquest" (Tier: 1) — Elemental, Cold }
576576
10(8-10)% chance to Avoid Cold Damage from Hits
577577
(No chance to avoid damage can be higher than 75%)
@@ -582,15 +582,15 @@ describe("TestAdvancedItemParse #item", function()
582582
end)
583583

584584
it("parses enchant correctly #enchant", function()
585-
local item = new("Item", raw([[
585+
local item = new("Item"):Item(raw([[
586586
{ Corrupted Enhancement }
587587
+8(6-10)% to Fire Resistance
588588
]]))
589589
assert.are.equals(8, item.enchantModLines[1].modList[1].value)
590590
end)
591591

592592
it("parses enchant with tags correctly #enchant", function()
593-
local item = new("Item", raw([[
593+
local item = new("Item"):Item(raw([[
594594
{ Corrupted Enhancement - Energy Shield }
595595
+8(6-10)% to Fire Resistance
596596
]]))
@@ -599,7 +599,7 @@ describe("TestAdvancedItemParse #item", function()
599599
end)
600600

601601
it("parses junk", function()
602-
local godTestItem = new("Item", [[
602+
local godTestItem = new("Item"):Item([[
603603
Item Class: Sceptres
604604
Rarity: Unique
605605
Nebulis
@@ -617,7 +617,7 @@ describe("TestAdvancedItemParse #item", function()
617617
Str: 104
618618
Int: 122
619619
--------
620-
Sockets: B R
620+
Sockets: B R
621621
--------
622622
Item Level: 87
623623
--------

spec/System/TestTradeQueryCurrency_spec.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe("TradeQuery Currency Conversion", function()
6767
it("aggregates prices", function()
6868
mock_tradeQuery.totalPrice = { { currency = "chaos", amount = 5 }, { currency = "div", amount = 10 } }
6969
local result = mock_tradeQuery:GetTotalPriceString()
70-
assert.are.equal(result, "5 chaos, 10 div")
70+
assert.are.equal(result, "10 div, 5 chaos")
7171
end)
7272
end)
7373
end)

0 commit comments

Comments
 (0)