Preserve cluster jewel notables when changing enchantment (#9513)

* Preserve cluster jewel notables when changing enchantment

Keep currently-selected affixes in the dropdown even when they
can't naturally spawn on the new base. In 3.28 you can change
a cluster jewel's enchantment without losing existing mods,
so the affix list filter now skips the spawn weight check for
whatever mod is already selected in each slot.

* Add [Retained] label to cluster jewel notables from previous enchant

Grey out notables in the affix dropdown that only appear because
they are currently selected but have zero spawn weight on the
active enchantment. This makes it clear which mods were carried
over from a different cluster jewel enchant.

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

Author: EtherealCarnivore

src/Classes/ItemsTab.lua

@@ -1816,10 +1816,17 @@ function ItemsTabClass:UpdateAffixControl(control, item, type, outputTable, outp
 			extraTags[skill.tag] = true
 		end
 	end
+	local selAffix = item[outputTable][outputIndex] and item[outputTable][outputIndex].modId
 	local affixList = { }
+	local retainedAffixes = { }
 	for modId, mod in pairs(item.affixes) do
-		if mod.type == type and not excludeGroups[mod.group] and item:GetModSpawnWeight(mod, extraTags) > 0 and not item:CheckIfModIsDelve(mod) then
-			t_insert(affixList, modId)
+		if mod.type == type and not excludeGroups[mod.group] and not item:CheckIfModIsDelve(mod) then
+			if item:GetModSpawnWeight(mod, extraTags) > 0 then
+				t_insert(affixList, modId)
+			elseif modId == selAffix then
+				t_insert(affixList, modId)
+				retainedAffixes[modId] = true
+			end
 		end
 	end
 	table.sort(affixList, function(a, b)
@@ -1854,7 +1861,9 @@ function ItemsTabClass:UpdateAffixControl(control, item, type, outputTable, outp
 			end
 			local modString = table.concat(mod, "/")
 			local label = modString
-			if item.type == "Flask" then
+			if retainedAffixes[modId] then
+				label = "^8[Retained] " .. modString
+			elseif item.type == "Flask" then
 				label = mod.affix .. "   ^8[" .. modString .. "]"
 			end
 			control.list[i + 1] = {