Skip to content

Commit 89c5181

Browse files
author
LocalIdentity
committed
Remove more quality stuff
1 parent 7e72a67 commit 89c5181

6 files changed

Lines changed: 10 additions & 26 deletions

File tree

src/Classes/GemSelectControl.lua

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ function GemSelectClass:CalcOutputWithThisGem(calcFunc, gemData, useFullDPS)
6161
else
6262
gemList[self.index] = {
6363
level = gemData.naturalMaxLevel,
64-
qualityId = "Default",
6564
quality = self.skillsTab.defaultGemQuality or 0,
6665
count = 1,
6766
enabled = true,
@@ -78,7 +77,6 @@ function GemSelectClass:CalcOutputWithThisGem(calcFunc, gemData, useFullDPS)
7877
gemInstance.level = self.skillsTab:ProcessGemLevel(gemData)
7978
gemInstance.gemData = gemData
8079
gemInstance.displayEffect = nil
81-
gemInstance.qualityId = "Default"
8280
-- Calculate the impact of using this gem
8381
local output = calcFunc(nil, useFullDPS)
8482
-- Put the original gem back into the list
@@ -471,7 +469,6 @@ function GemSelectClass:Draw(viewPort, noTooltip)
471469
local output= self:CalcOutputWithThisGem(calcFunc, gemData, self.skillsTab.sortGemsByDPSField == "FullDPS")
472470
local gemInstance = {
473471
level = self.skillsTab:ProcessGemLevel(gemData),
474-
qualityId = "Default",
475472
quality = self.skillsTab.defaultGemQuality or 0,
476473
count = 1,
477474
enabled = true,
@@ -512,7 +509,6 @@ function GemSelectClass:Draw(viewPort, noTooltip)
512509
local cursorX, cursorY = GetCursorPos()
513510
self.tooltip:Clear()
514511
if gemInstance and gemInstance.gemData then
515-
gemInstance.qualityId = "Default"
516512
self:AddGemTooltip(gemInstance)
517513
else
518514
self.tooltip:AddLine(16, toolTipText)

src/Classes/ImportTab.lua

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,11 +1116,11 @@ function ImportTabClass:ImportSocketedItems(item, socketedItems, slotName)
11161116
self:ImportItem(socketedItem, slotName .. " Abyssal Socket "..abyssalSocketId)
11171117
abyssalSocketId = abyssalSocketId + 1
11181118
else
1119-
local normalizedBasename, qualityType = sanitiseText(socketedItem.typeLine)
1119+
local normalizedBasename = sanitiseText(socketedItem.typeLine)
11201120
local gemId = self.build.data.gemForBaseName[normalizedBasename:lower()]
11211121
if socketedItem.hybrid then
11221122
-- Used by transfigured gems and dual-skill gems (currently just Stormbind)
1123-
normalizedBasename, qualityType = sanitiseText(socketedItem.hybrid.baseTypeName)
1123+
normalizedBasename = sanitiseText(socketedItem.hybrid.baseTypeName)
11241124
gemId = self.build.data.gemForBaseName[normalizedBasename:lower()]
11251125
if gemId and socketedItem.hybrid.isVaalGem then
11261126
gemId = self.build.data.gemGrantedEffectIdForVaalGemId[self.build.data.gems[gemId].grantedEffectId]
@@ -1130,7 +1130,6 @@ function ImportTabClass:ImportSocketedItems(item, socketedItems, slotName)
11301130
local gemInstance = { level = 20, quality = 0, enabled = true, enableGlobal1 = true, gemId = gemId }
11311131
gemInstance.nameSpec = self.build.data.gems[gemId].name
11321132
gemInstance.support = socketedItem.support
1133-
gemInstance.qualityId = qualityType
11341133
for _, property in pairs(socketedItem.properties) do
11351134
if property.name == "Level" then
11361135
gemInstance.level = tonumber(property.values[1][1]:match("%d+"))

src/Export/Scripts/skills.lua

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -404,10 +404,10 @@ directiveTable.skill = function(state, args, out)
404404
if not skill.qualityStats then
405405
skill.qualityStats = { }
406406
for i, qualityStatsRow in ipairs(dat("GrantedEffectQualityStats"):GetRowList("GrantedEffect", granted)) do
407-
skill.qualityStats[i] = { }
407+
skill.qualityStats.Default = { }
408408
for j, stat in ipairs(qualityStatsRow.GrantedStats) do
409-
table.insert(skill.qualityStats[i], { stat.Id, qualityStatsRow.StatValues[j] / 1000 })
410-
--ConPrintf("[%d] %s %s", i, granted.ActiveSkill.DisplayName, stat.Id)
409+
table.insert(skill.qualityStats.Default, { stat.Id, qualityStatsRow.StatValues[j] / 1000 })
410+
--ConPrintf("%s %s", granted.ActiveSkill.DisplayName, stat.Id)
411411
end
412412
end
413413
end
@@ -454,18 +454,11 @@ directiveTable.mods = function(state, args, out)
454454
if not args:match("noQualityStats") then
455455
if next(skill.qualityStats) ~= nil then
456456
out:write('\tqualityStats = {\n')
457-
for i, alternates in ipairs(skill.qualityStats) do
458-
if i == 1 then
459-
out:write('\t\tDefault = {\n')
460-
else
461-
local value = i - 1
462-
out:write('\t\tAlternate' .. value .. ' = {\n')
463-
end
464-
for _, stat in ipairs(alternates) do
465-
out:write('\t\t\t{ "', stat[1], '", ', stat[2], ' },\n')
466-
end
467-
out:write('\t\t},\n')
457+
out:write('\t\tDefault = {\n')
458+
for _, stat in ipairs(skill.qualityStats.Default or skill.qualityStats) do
459+
out:write('\t\t\t{ "', stat[1], '", ', stat[2], ' },\n')
468460
end
461+
out:write('\t\t},\n')
469462
out:write('\t},\n')
470463
end
471464
end

src/Modules/CalcActiveSkill.lua

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ function calcs.copyActiveSkill(env, mode, skill)
171171
if skill.activeEffect.srcInstance then
172172
activeEffect.level = skill.activeEffect.srcInstance.level
173173
activeEffect.quality = skill.activeEffect.srcInstance.quality
174-
activeEffect.qualityId = skill.activeEffect.srcInstance.qualityId
175174
activeEffect.srcInstance = skill.activeEffect.srcInstance
176175
activeEffect.gemData = skill.activeEffect.srcInstance.gemData
177176
end

src/Modules/CalcSetup.lua

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,7 +1523,6 @@ function calcs.initEnv(build, mode, override, specEnv)
15231523
grantedEffect = grantedEffect,
15241524
level = gemInstance.level,
15251525
quality = gemInstance.quality,
1526-
qualityId = gemInstance.qualityId,
15271526
srcInstance = gemInstance,
15281527
gemData = gemInstance.gemData,
15291528
superseded = false,
@@ -1595,7 +1594,6 @@ function calcs.initEnv(build, mode, override, specEnv)
15951594
grantedEffect = grantedEffect,
15961595
level = gemInstance.level,
15971596
quality = gemInstance.quality,
1598-
qualityId = gemInstance.qualityId,
15991597
srcInstance = gemInstance,
16001598
gemData = gemInstance.gemData,
16011599
}

src/Modules/CalcTools.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,7 @@ end
176176
function calcLib.buildSkillInstanceStats(skillInstance, grantedEffect)
177177
local stats = { }
178178
if skillInstance.quality > 0 and grantedEffect.qualityStats then
179-
local qualityId = skillInstance.qualityId or "Default"
180-
local qualityStats = grantedEffect.qualityStats[qualityId]
179+
local qualityStats = grantedEffect.qualityStats.Default
181180
if not qualityStats then
182181
qualityStats = grantedEffect.qualityStats
183182
end

0 commit comments

Comments
 (0)