rename constructors to init instead of the class name

Author: vaisest

spec/System/TestCommon_spec.lua

@@ -2,46 +2,46 @@ describe("Common", function()
 	describe("Class creation and use", function()
 		it("produces error when parent constructors are not called", function()
 			local ParentClass = newClass("ConstructorTestParentClass")
-			function ParentClass:ConstructorTestParentClass()
+			function ParentClass:init()
 				return self
 			end
 			local ChildClass = newClass("ConstructorTestProblemChildClass", "ConstructorTestParentClass")
-			function ChildClass:ConstructorTestProblemChild()
+			function ChildClass:init()
 				-- Intentionally does not call self:ConstructorTestParentClass()
 				return self
 			end
 			common.classes.ConstructorTestParent = ParentClass
 			common.classes.ConstructorTestProblemChild = ChildClass
 
 			assert.has_error(function()
-				new("ConstructorTestProblemChild"):ConstructorTestProblemChild()
+				new("ConstructorTestProblemChild"):init()
 			end, "Parent class 'ConstructorTestParentClass' of class 'ConstructorTestProblemChild' must be initialised")
 			common.classes.ConstructorTestParent = nil
 			common.classes.ConstructorTestProblemChild = nil
 		end)
 		it("produces an error if additional arguments are passed", function()
 			local StupidClass = newClass("NewAbuse")
-			function StupidClass:NewAbuse(someParam)
+			function StupidClass:init(someParam)
 				return self
 			end
 
 			common.classes.NewAbuse = StupidClass
 
 			assert.has_no.errors(function()
-				local newObj = new("NewAbuse"):NewAbuse("fish")
+				local newObj = new("NewAbuse"):init("fish")
 			end)
 			assert.has_error(function()
 				local newObj = new("NewAbuse", "look I'm using the old syntax")
 			end)
 		end)
 		it("produces an error if it calls a parent class without giving it self", function()
 			local ParentClass = newClass("ConstructorTestParentClass")
-			function ParentClass:ConstructorTestParentClass()
+			function ParentClass:init()
 				return self
 			end
 
 			local ChildClass = newClass("ConstructorTestProblemChildClass", "ConstructorTestParentClass")
-			function ChildClass:ConstructorTestProblemChild()
+			function ChildClass:init()
 				self.ConstructorTestParentClass()
 				return self
 			end
@@ -50,20 +50,20 @@ describe("Common", function()
 			common.classes.ConstructorTestProblemChild = ChildClass
 
 			assert.has_error(function()
-				new("ConstructorTestProblemChild"):ConstructorTestProblemChild()
+				new("ConstructorTestProblemChild"):init()
 			end)
 			common.classes.ConstructorTestParent = nil
 			common.classes.ConstructorTestProblemChild = nil
 		end)
 		it("produces an error if its constructor doesn't return the object", function()
 			local StupidClass = newClass("StupidClass")
-			function StupidClass:StupidClass()
+			function StupidClass:init()
 			end
 
 			common.classes.StupidClass = StupidClass
 
 			assert.has_error(function()
-				new("StupidClass"):StupidClass()
+				new("StupidClass"):init()
 			end, "Class StupidClass constructor did not return a value")
 		end)
 	end)

spec/System/TestCompareBuySimilar_spec.lua

@@ -4,7 +4,7 @@ describe("Buy similar mod stat matching", function()
 
 	describe("addModEntries mod matching", function()
 		it("matches impossible escape mods as options", function()
-			local fromNothing = new("Item"):Item([[
+			local fromNothing = new("Item"):init([[
 Impossible Escape
 Viridian Jewel
 LevelReq: 0
@@ -32,7 +32,7 @@ Corrupted]])
 		end)
 
 		it("matches thread of hope radius as an option", function()
-			local thread = new("Item"):Item([[
+			local thread = new("Item"):init([[
 Rarity: UNIQUE
 Thread of Hope
 Crimson Jewel
@@ -52,7 +52,7 @@ Passage]])
 		end)
 
 		it("combines mods that are the same stat", function()
-			local lifeDiamond = new("Item"):Item([[
+			local lifeDiamond = new("Item"):init([[
 Test Subject
 Diamond
 Implicits: 0
@@ -67,7 +67,7 @@ Implicits: 0
 			assert.equal("+50 to Maximum Life", StripEscapes(entries[1].formattedLines[2]))
 			assert.equal(150, entries[1].value)
 
-			local lifelessDiamond = new("Item"):Item([[
+			local lifelessDiamond = new("Item"):init([[
 Test Subject
 Diamond
 Implicits: 0
@@ -82,7 +82,7 @@ Implicits: 0
 		end)
 
 		it("is not case-sensitive", function ()
-			local funnyItem = new("Item"):Item([[
+			local funnyItem = new("Item"):init([[
 Test Subject
 Diamond
 Implicits: 1
@@ -93,7 +93,7 @@ Implicits: 1
 		end)
 
 		it("does not combine implicit and explicit mods", function()
-			local lifelessDiamond = new("Item"):Item([[
+			local lifelessDiamond = new("Item"):init([[
 Test Subject
 Diamond
 Implicits: 1
@@ -140,7 +140,7 @@ Implicits: 1
 		end)
 
 		local function openPopup(item, slotName)
-			item = item or new("Item"):Item("Rarity: Rare\nTest Ring\nRuby Ring\nImplicits: 0\n+50 to maximum Life")
+			item = item or new("Item"):init("Rarity: Rare\nTest Ring\nRuby Ring\nImplicits: 0\n+50 to maximum Life")
 			bs.openPopup(item, slotName or "Ring", build)
 			local controls = main.popups[1].controls
 			_G.Copy = function(url) copiedUrl = url end
@@ -194,7 +194,7 @@ Implicits: 1
 		end)
 
 		it("encodes option values in the generated query", function()
-			local item = new("Item"):Item([[
+			local item = new("Item"):init([[
 Rarity: UNIQUE
 Impossible Escape
 Viridian Jewel
@@ -214,7 +214,7 @@ Corrupted]])
 		end)
 
 		it("inverts reduced stat bounds in the generated query", function()
-			local item = new("Item"):Item([[
+			local item = new("Item"):init([[
 Rarity: Rare
 Test Ring
 Ruby Ring
@@ -230,7 +230,7 @@ Implicits: 0
 		end)
 
 		it("uses a count group for ambiguous trade stats", function()
-			local item = new("Item"):Item([[
+			local item = new("Item"):init([[
 Rarity: Rare
 Test Ring
 Ruby Ring

spec/System/TestImport_spec.lua

@@ -71,7 +71,7 @@ describe("TestImport", function()
 	end)
 
 	function importAndReimportWithOldJewel(shouldDelete)
-		local oldJewel = new("Item"):Item([[Rarity: RARE
+		local oldJewel = new("Item"):init([[Rarity: RARE
 TEST JEWEL
 Crimson Jewel
 Crafted: true

spec/System/TestItemDBControl_spec.lua

@@ -33,7 +33,7 @@ describe("ItemDBControl", function()
 				return item ~= invalidItem
 			end,
 		}
-		local control = new("ItemDBControl"):ItemDBControl(nil, { 0, 0, 100, 100 }, itemsTab, {
+		local control = new("ItemDBControl"):init(nil, { 0, 0, 100, 100 }, itemsTab, {
 			list = { invalidItem, betterItem, worseItem },
 		}, "RARE")
 		control.sortDetail = {

spec/System/TestItemMods_spec.lua

@@ -614,12 +614,12 @@ describe("TetsItemMods", function()
 	end)
 
 	it("shows a fallback tooltip when an item's base is no longer supported", function()
-		local item = new("Item"):Item([[
+		local item = new("Item"):init([[
 			Rarity: Unique
 			Legacy Item
 			Removed Base
 		]])
-		local tooltip = new("Tooltip"):Tooltip()
+		local tooltip = new("Tooltip"):init()
 
 		assert.has_no.errors(function()
 			build.itemsTab:AddItemTooltip(tooltip, item)