Skip to content

Commit a20c100

Browse files
author
LocalIdentity
committed
Fix Ele Hit handling and breakdown
Only the base damage granted via ele hit is not meant to be converted. Mods from gear are meant to work still The breakdown now shows a note on the mods that are converted that the cryogenesis node is what is changing them
1 parent 161d3c4 commit a20c100

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

src/Modules/CalcOffence.lua

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3059,17 +3059,18 @@ function calcs.offence(env, actor, activeSkill)
30593059
addedDamageRedirectType = "Cold"
30603060
end
30613061
if addedDamageRedirectType then
3062-
local skipRedirect = activeSkill.activeEffect.grantedEffect.name == "Elemental Hit"
3063-
if not skipRedirect then
3064-
for _, damageType in ipairs(dmgTypeList) do
3065-
if damageType ~= addedDamageRedirectType then
3066-
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Min")) do
3067-
local mod = value.mod
3068-
skillModList:ConvertMod(damageType.."Min", addedDamageRedirectType.."Min", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, unpack(mod))
3062+
for _, damageType in ipairs(dmgTypeList) do
3063+
if damageType ~= addedDamageRedirectType then
3064+
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Min")) do
3065+
local mod = value.mod
3066+
if mod.source ~= "Skill:ElementalHit" then
3067+
skillModList:ConvertMod(damageType.."Min", addedDamageRedirectType.."Min", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, { type = "Cryogenesis Added Damage" }, unpack(mod))
30693068
end
3070-
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Max")) do
3071-
local mod = value.mod
3072-
skillModList:ConvertMod(damageType.."Max", addedDamageRedirectType.."Max", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, unpack(mod))
3069+
end
3070+
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Max")) do
3071+
local mod = value.mod
3072+
if mod.source ~= "Skill:ElementalHit" then
3073+
skillModList:ConvertMod(damageType.."Max", addedDamageRedirectType.."Max", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, { type = "Cryogenesis Added Damage" }, unpack(mod))
30733074
end
30743075
end
30753076
end

0 commit comments

Comments
 (0)