Skip UI path rebuilds for jewel tooltip specs

Tooltip comparison specs only need calc state, but radius jewel comparisons
were still rebuilding passive tree UI paths for every temporary spec.
Skip that path rebuild while preserving socket distance recomputation for
Split Personality-style jewel scaling.

Author: mcagnion

spec/System/TestRadiusJewelStatDiff_spec.lua

@@ -201,6 +201,15 @@ local function newPlainJewel()
 		"Implicits: 0\n")
 end
 
+local function newSplitPersonality()
+	return new("Item", "Rarity: UNIQUE\n" ..
+		"Split Personality\n" ..
+		"Crimson Jewel\n" ..
+		"Implicits: 0\n" ..
+		"+5 to Strength\n" ..
+		"This Jewel's Socket has 25% increased effect per Allocated Passive Skill between it and your Class' starting location\n")
+end
+
 -- Helper: minimal Impossible Escape item. Uses "Radius: Small" and targets
 -- a specific keystone. The parser populates both impossibleEscapeKeystone
 -- and impossibleEscapeKeystones from the "in Radius of X" mod.
@@ -695,4 +704,50 @@ describe("TestRadiusJewelStatDiff", function()
 		end
 	end)
 
+	it("AddItemTooltip skips UI path rebuilds for temporary radius jewel specs", function()
+		local spec, sockets = setupAllocatedSockets(2)
+
+		local radiusItem = newThreadOfHope()
+		local radiusSlot = equipJewelInSocket(radiusItem, sockets[1])
+		local splitItem = newSplitPersonality()
+		equipJewelInSocket(splitItem, sockets[2])
+		spec:BuildAllDependsAndPaths()
+		runCallback("OnFrame")
+
+		assert.is_true((spec.nodes[sockets[2].id].distanceToClassStart or 0) > 0,
+			"Split Personality socket should have a class-start distance in the base spec")
+
+		local originalSlotOnlyTooltips = main.slotOnlyTooltips
+		main.slotOnlyTooltips = true
+		local specClass = getmetatable(spec)
+		local originalBuildPathFromNode = specClass.BuildPathFromNode
+		local originalSetNodeDistanceToClassStart = specClass.SetNodeDistanceToClassStart
+		local buildPathCalls = 0
+		local distanceCalls = 0
+		specClass.BuildPathFromNode = function(self, ...)
+			buildPathCalls = buildPathCalls + 1
+			return originalBuildPathFromNode(self, ...)
+		end
+		specClass.SetNodeDistanceToClassStart = function(self, ...)
+			distanceCalls = distanceCalls + 1
+			return originalSetNodeDistanceToClassStart(self, ...)
+		end
+
+		local ok, err = pcall(function()
+			local tooltip = new("Tooltip")
+			build.itemsTab:AddItemTooltip(tooltip, radiusItem, radiusSlot)
+		end)
+		specClass.BuildPathFromNode = originalBuildPathFromNode
+		specClass.SetNodeDistanceToClassStart = originalSetNodeDistanceToClassStart
+		main.slotOnlyTooltips = originalSlotOnlyTooltips
+		if not ok then
+			error(err)
+		end
+
+		assert.are.equals(0, buildPathCalls,
+			"temporary tooltip specs should not rebuild UI node paths")
+		assert.is_true(distanceCalls > 0,
+			"temporary tooltip specs should still refresh jewel socket distances used by calc")
+	end)
+
 end)

src/Classes/ItemsTab.lua

@@ -3834,7 +3834,7 @@ local function cloneSpecForJewelComparison(spec)
 		local nodeCopy = setmetatable({ }, getmetatable(node))
 		for key, value in pairs(node) do
 			if key ~= "linked" and key ~= "depends" and key ~= "intuitiveLeapLikesAffecting"
-			and key ~= "path" and key ~= "power" then
+			and key ~= "path" and key ~= "pathDist" and key ~= "distanceToClassStart" and key ~= "power" then
 				nodeCopy[key] = value
 			end
 		end
@@ -3914,7 +3914,8 @@ local function buildSpecForJewelComparison(itemsTab, compareSlot, replacementIte
 	end
 
 	local ok, err = xpcall(function()
-		spec:BuildAllDependsAndPaths()
+		-- Tooltip comparison specs only need calc state; node paths are UI data.
+		spec:BuildAllDependsAndPaths(true)
 	end, debug.traceback)
 	if tempItemId then
 		itemsTab.items[tempItemId] = nil

src/Classes/PassiveSpec.lua

@@ -1088,7 +1088,7 @@ function PassiveSpecClass:NodesInIntuitiveLeapLikeRadius(node)
 end
 
 -- Rebuilds dependencies and paths for all nodes
-function PassiveSpecClass:BuildAllDependsAndPaths()
+function PassiveSpecClass:BuildAllDependsAndPaths(skipNodePathRebuild)
 	-- This table will keep track of which nodes have been visited during each path-finding attempt
 	local visited = { }
 	local attributes = { "Dexterity", "Intelligence", "Strength" }
@@ -1546,15 +1546,22 @@ function PassiveSpecClass:BuildAllDependsAndPaths()
 
 	-- Reset and rebuild all node paths
 	for id, node in pairs(self.nodes) do
-		node.pathDist = (node.alloc and #node.intuitiveLeapLikesAffecting == 0) and 0 or 1000
-		node.path = nil
+		if skipNodePathRebuild then
+			node.pathDist = nil
+			node.path = nil
+		else
+			node.pathDist = (node.alloc and #node.intuitiveLeapLikesAffecting == 0) and 0 or 1000
+			node.path = nil
+		end
 		if node.isJewelSocket or node.expansionJewel then
 			node.distanceToClassStart = 0
 		end
 	end
 	for id, node in pairs(self.allocNodes) do
 		if #node.intuitiveLeapLikesAffecting == 0 or node.connectedToStart then
-			self:BuildPathFromNode(node)
+			if not skipNodePathRebuild then
+				self:BuildPathFromNode(node)
+			end
 			if node.isJewelSocket or node.expansionJewel then
 				self:SetNodeDistanceToClassStart(node)
 			end