Rework Cryogenesis to use ConvertMod, match 3.28 tree wording

ModParser entries now match the actual 3.28 tree text instead of
guessed wording. Handles the "Lighting" typo with a pattern.

CalcOffence uses ConvertMod to redirect added damage mods before the
damage loop so breakdowns show the source properly. Base Elemental
Hit is excluded per the node text.

Added ConvertMod to ModStore/ModList/ModDB - like ReplaceMod but
matches by oldName so it can change a mod's identity.

Author: EtherealCarnivore

src/Modules/CalcOffence.lua

@@ -3048,35 +3048,42 @@ function calcs.offence(env, actor, activeSkill)
 
 		runSkillFunc("postCritFunc")
 
-		-- Check for added damage redirection (Cryogenesis)
+		-- Added damage redirection (Cryogenesis)
+		-- Convert all added damage mods to the target type before the damage loop
+		-- so breakdowns show the redirected source correctly.
+		-- Base Elemental Hit is excluded per the node text.
 		local addedDamageRedirectType = nil
 		if skillModList:Flag(cfg, "AllAddedDamageAsLightning") then
 			addedDamageRedirectType = "Lightning"
 		elseif skillModList:Flag(cfg, "AllAddedDamageAsCold") then
 			addedDamageRedirectType = "Cold"
 		end
+		if addedDamageRedirectType then
+			local skipRedirect = activeSkill.activeEffect.grantedEffect.name == "Elemental Hit"
+			if not skipRedirect then
+				for _, damageType in ipairs(dmgTypeList) do
+					if damageType ~= addedDamageRedirectType then
+						for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Min")) do
+							local mod = value.mod
+							skillModList:ConvertMod(damageType.."Min", addedDamageRedirectType.."Min", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, unpack(mod))
+						end
+						for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Max")) do
+							local mod = value.mod
+							skillModList:ConvertMod(damageType.."Max", addedDamageRedirectType.."Max", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, unpack(mod))
+						end
+					end
+				end
+			end
+		end
 
 		-- Calculate base hit damage
 		for _, damageType in ipairs(dmgTypeList) do
 			local damageTypeMin = damageType.."Min"
 			local damageTypeMax = damageType.."Max"
 			local baseMultiplier = activeSkill.activeEffect.grantedEffectLevel.baseMultiplier or skillData.baseMultiplier or 1
 			local damageEffectiveness = activeSkill.activeEffect.grantedEffectLevel.damageEffectiveness or skillData.damageEffectiveness or 1
-			local addedMin, addedMax
-			if addedDamageRedirectType then
-				if damageType == addedDamageRedirectType then
-					addedMin, addedMax = 0, 0
-					for _, srcType in ipairs(dmgTypeList) do
-						addedMin = addedMin + skillModList:Sum("BASE", cfg, srcType.."Min") + enemyDB:Sum("BASE", cfg, "Self"..srcType.."Min")
-						addedMax = addedMax + skillModList:Sum("BASE", cfg, srcType.."Max") + enemyDB:Sum("BASE", cfg, "Self"..srcType.."Max")
-					end
-				else
-					addedMin, addedMax = 0, 0
-				end
-			else
-				addedMin = skillModList:Sum("BASE", cfg, damageTypeMin) + enemyDB:Sum("BASE", cfg, "Self"..damageTypeMin)
-				addedMax = skillModList:Sum("BASE", cfg, damageTypeMax) + enemyDB:Sum("BASE", cfg, "Self"..damageTypeMax)
-			end
+			local addedMin = skillModList:Sum("BASE", cfg, damageTypeMin) + enemyDB:Sum("BASE", cfg, "Self"..damageTypeMin)
+			local addedMax = skillModList:Sum("BASE", cfg, damageTypeMax) + enemyDB:Sum("BASE", cfg, "Self"..damageTypeMax)
 			local addedMult = calcLib.mod(skillModList, cfg, "Added"..damageType.."Damage", "AddedDamage")
 			local baseMin = ((source[damageTypeMin] or 0) + (source[damageType.."BonusMin"] or 0)) * baseMultiplier + addedMin * damageEffectiveness * addedMult
 			local baseMax = ((source[damageTypeMax] or 0) + (source[damageType.."BonusMax"] or 0)) * baseMultiplier + addedMax * damageEffectiveness * addedMult

src/Modules/ModParser.lua

@@ -5286,12 +5286,13 @@ local specialModList = {
 	["consecrated path and purifying flame create profane ground instead of consecrated ground"] = {
 		flag("Condition:CreateProfaneGround"),
 	},
-	["if intelligence is your single highest attribute, all added damage is treated as added lightning damage"] = {
-		flag("AllAddedDamageAsLightning", { type = "Condition", var = "IntSingleHighestAttribute" }),
-	},
-	["if dexterity is your single highest attribute, all added damage is treated as added cold damage"] = {
+	["you gain added cold damage instead of added damage of other types if dexterity exceeds both other attributes"] = {
 		flag("AllAddedDamageAsCold", { type = "Condition", var = "DexSingleHighestAttribute" }),
 	},
+	["you gain added lightn?ing damage instead of added damage of other types if intelligence exceeds both other attributes"] = {
+		flag("AllAddedDamageAsLightning", { type = "Condition", var = "IntSingleHighestAttribute" }),
+	},
+	["elemental hit's added damage cannot be replaced this way"] = { },
 	["you have consecrated ground around you while stationary if strength is your highest attribute"] = {
 		flag("Condition:OnConsecratedGround", { type = "Condition", var = "StrHighestAttribute" }, { type = "Condition", var = "Stationary" }),
 	},