Make source assignment non-mutating

Author: Nostrademous

src/Modules/CalcPerform.lua

@@ -584,7 +584,7 @@ local function applyEnemyModifiers(actor, clearCache)
 		local mod = value.value and value.value.mod
 		if mod and not cache[mod] then
 			local source = mod.source or value.mod.source
-			enemyDB:AddMod(modLib.setSource(mod, source))
+			enemyDB:AddMod(modLib.withSource(mod, source))
 			cache[mod] = true
 		end
 	end
@@ -1753,8 +1753,7 @@ function calcs.perform(env, skipEHP)
 			for _, value in ipairs(env.modDB:Tabulate(nil, nil, "EnemyModifier")) do
 				local mod = value.value and value.value.mod
 				if mod then
-					local copy = copyTable(mod, true)
-					env.minion.modDB:AddMod(modLib.setSource(copy, mod.source or value.mod.source))
+					env.minion.modDB:AddMod(modLib.withSource(mod, mod.source or value.mod.source))
 				end
 			end
 		end
@@ -2025,23 +2024,20 @@ function calcs.perform(env, skipEHP)
 					buffs["Spectre"] = buffs["Spectre"] or new("ModList")
 					minionBuffs["Spectre"] = minionBuffs["Spectre"] or new("ModList")
 					for _, modValue in pairs(modData.value) do
-						local copyModValue = copyTable(modValue)
-						copyModValue.source = "Spectre:"..spectreData.name
+						local copyModValue = modLib.withSource(modValue, "Spectre:"..spectreData.name)
 						t_insert(minionBuffs["Spectre"], copyModValue)
 						t_insert(buffs["Spectre"], copyModValue)
 					end
 				elseif modData.name == "MinionModifier" and modData.type == "LIST" then
 					minionBuffs["Spectre"] = minionBuffs["Spectre"] or new("ModList")
 					for _, modValue in pairs(modData.value) do
-						local copyModValue = copyTable(modValue)
-						copyModValue.source = "Spectre:"..spectreData.name
+						local copyModValue = modLib.withSource(modValue, "Spectre:"..spectreData.name)
 						t_insert(minionBuffs["Spectre"], copyModValue)
 					end
 				elseif modData.name == "PlayerModifier" and modData.type == "LIST" then
 					buffs["Spectre"] = buffs["Spectre"] or new("ModList")
 					for _, modValue in pairs(modData.value) do
-						local copyModValue = copyTable(modValue)
-						copyModValue.source = "Spectre:"..spectreData.name
+						local copyModValue = modLib.withSource(modValue, "Spectre:"..spectreData.name)
 						t_insert(buffs["Spectre"], copyModValue)
 					end
 				end
@@ -2557,7 +2553,7 @@ function calcs.perform(env, skipEHP)
 						source = source..castingMinion.minionData.name
 					end
 					for i = 1, #modList do
-						modList[i].source = source
+						modList[i] = modLib.withSource(modList[i], source)
 					end
 				end
 			end

src/Modules/CalcSetup.lua

@@ -310,7 +310,7 @@ local function applySocketMods(env, gem, groupCfg, socketNum, modSource)
 	socketCfg.skillGem = gem
 	socketCfg.socketNum = socketNum
 	for _, value in ipairs(env.modDB:List(socketCfg, "SocketProperty")) do
-		env.player.modDB:AddMod(modLib.setSource(value.value, modSource or groupCfg.slotName or ""))
+		env.player.modDB:AddMod(modLib.withSource(value.value, modSource or groupCfg.slotName or ""))
 	end
 end
 
@@ -1054,9 +1054,7 @@ function calcs.initEnv(build, mode, override, specEnv)
 								end
 							end
 
-							local modCopy = copyTable(mod)
-							modLib.setSource(modCopy, item.modSource)
-							env.itemModDB:ScaleAddMod(modCopy, scale)
+							env.itemModDB:ScaleAddMod(modLib.withSource(mod, item.modSource), scale)
 
 							::skip_mod::
 						end
@@ -1684,7 +1682,7 @@ function calcs.initEnv(build, mode, override, specEnv)
 				}
 				local groupCfg = groupCfgList[slotName or "noSlot"][group]
 				for _, value in ipairs(env.modDB:List(groupCfg, "GroupProperty")) do
-					env.player.modDB:AddMod(modLib.setSource(value.value, groupCfg.slotName or ""))
+					env.player.modDB:AddMod(modLib.withSource(value.value, groupCfg.slotName or ""))
 				end
 
 				if index == env.mainSocketGroup and #socketGroupSkillList > 0 then

src/Modules/ModTools.lua

@@ -214,6 +214,16 @@ function modLib.formatSourceMod(mod)
     return s_format("%s|%s|%s", modLib.formatValue(mod.value), mod.source, modLib.formatModParams(mod))
 end
 
+function modLib.withSource(mod, source)
+	local copy = copyTableSafe(mod, false)
+	copy.source = source
+	if type(copy.value) == "table" and copy.value.mod then
+		copy.value.mod.source = source
+	end
+	return copy
+end
+
+-- Deprecated: internal-only helper that mutates the provided mod; prefer withSource for shared mods.
 function modLib.setSource(mod, source)
 	mod.source = source
 	if type(mod.value) == "table" and mod.value.mod then
@@ -230,8 +240,8 @@ function modLib.mergeKeystones(env, modDB)
 			env.keystonesAdded[modObj.value] = true
 			local fromTree = modObj.mod.source and not modObj.mod.source:lower():match("tree")
 			for _, mod in ipairs(env.spec.tree.keystoneMap[modObj.value].modList) do
-				modDB:AddMod(fromTree and modLib.setSource(mod, modObj.mod.source) or mod)
+				modDB:AddMod(fromTree and modLib.withSource(mod, modObj.mod.source) or mod)
 			end
 		end
 	end
-end
+end