Skip to content

Commit ddd0a0b

Browse files
authored
Fix filtering Support gems in SkillsTab (#9669)
* fix exceptional support gem filtering * update the gemList populate * only show plusVersionOf for legacy gems like Awakened... otherwise only Exceptional tag * update other conditional as well
1 parent 048e53f commit ddd0a0b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/Classes/GemSelectControl.lua

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ function GemSelectClass:PopulateGemList()
115115
if (self.sortGemsBy and gemData.tags[self.sortGemsBy] == true or not self.sortGemsBy) then
116116
local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1
117117
if characterLevel >= levelRequirement or not matchLevel then
118-
if (showExceptional or showAll) and gemData.grantedEffect.plusVersionOf then
118+
if (showExceptional or showAll) and ((gemData.grantedEffect.legacy and gemData.grantedEffect.plusVersionOf) or gemData.tagString:match("Exceptional")) then
119119
if self.skillsTab.showLegacyGems or not gemData.grantedEffect.legacy then
120120
self.gems["Default:" .. gemId] = gemData
121121
end
@@ -139,13 +139,14 @@ end
139139

140140
function GemSelectClass:FilterSupport(gemId, gemData)
141141
local showSupportTypes = self.skillsTab.showSupportGemTypes
142+
local isLegacyAwakened = (gemData.grantedEffect.legacy and gemData.grantedEffect.plusVersionOf)
142143
if gemData.grantedEffect.legacy and not self.skillsTab.showLegacyGems then
143144
return false
144145
end
145146
return (not gemData.grantedEffect.support
146147
or showSupportTypes == "ALL"
147-
or (showSupportTypes == "NORMAL" and not gemData.grantedEffect.plusVersionOf)
148-
or (showSupportTypes == "EXCEPTIONAL" and gemData.grantedEffect.plusVersionOf))
148+
or (showSupportTypes == "NORMAL" and not (isLegacyAwakened or gemData.tagString:match("Exceptional")))
149+
or (showSupportTypes == "EXCEPTIONAL" and (isLegacyAwakened or gemData.tagString:match("Exceptional"))))
149150
and (self.skillsTab.showAltQualityGems or (not self.skillsTab.showAltQualityGems and self:GetQualityType(gemId) == "Default"))
150151
end
151152

0 commit comments

Comments
 (0)