Skip to content

Commit eb6cc4c

Browse files
committed
update compare tab top content layout/spacing
1 parent 860ff95 commit eb6cc4c

1 file changed

Lines changed: 15 additions & 10 deletions

File tree

src/Classes/CompareTab.lua

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ local CLUSTER_NODE_OFFSET = 65536
2020
-- Layout constants (shared across Draw, DrawConfig, DrawItems, DrawCalcs, etc.)
2121
local LAYOUT = {
2222
-- Main tab control bar
23-
controlBarHeight = 96,
23+
controlBarHeight = 126,
2424

2525
-- Tree view header/footer
2626
treeHeaderHeight = 58,
@@ -193,7 +193,7 @@ function CompareTabClass:InitControls()
193193
end
194194

195195
-- Build B selector dropdown
196-
self.controls.compareBuildLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -70, 0, 16}, "^7Compare with:")
196+
self.controls.compareBuildLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -88, 0, 16}, "^7Compare with:")
197197
self.controls.compareBuildSelect = new("DropDownControl", {"LEFT", self.controls.compareBuildLabel, "RIGHT"}, {4, 0, 250, 20}, {}, function(index, value)
198198
if index and index > 0 and index <= #self.compareEntries then
199199
self.activeCompareIndex = index
@@ -250,11 +250,8 @@ function CompareTabClass:InitControls()
250250
return #self.compareEntries > 0
251251
end
252252

253-
self.controls.compareSetsLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -44, 0, 16}, "^7Sets:")
254-
self.controls.compareSetsLabel.shown = setsEnabled
255-
256253
-- Tree spec selector for comparison build
257-
self.controls.compareSpecLabel = new("LabelControl", {"LEFT", self.controls.compareSetsLabel, "RIGHT"}, {4, 0, 0, 16}, "^7Tree set:")
254+
self.controls.compareSpecLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -54, 0, 16}, "^7Tree set:")
258255
self.controls.compareSpecLabel.shown = setsEnabled
259256
self.controls.compareSpecSelect = new("DropDownControl", {"LEFT", self.controls.compareSpecLabel, "RIGHT"}, {2, 0, 150, 20}, {}, function(index, value)
260257
local entry = self:GetActiveCompare()
@@ -314,7 +311,7 @@ function CompareTabClass:InitControls()
314311
-- ============================================================
315312
-- Comparison build main skill selector (row between sets and sub-tabs)
316313
-- ============================================================
317-
self.controls.cmpSkillLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -22, 0, 16}, "^7Skill:")
314+
self.controls.cmpSkillLabel = new("LabelControl", {"TOPLEFT", self.controls.subTabAnchor, "TOPLEFT"}, {0, -32, 0, 16}, "^7Skill:")
318315
self.controls.cmpSkillLabel.shown = setsEnabled
319316

320317
-- Socket group dropdown
@@ -1650,7 +1647,15 @@ end
16501647
function CompareTabClass:Draw(viewPort, inputEvents)
16511648
-- Position top-bar controls
16521649
self.controls.subTabAnchor.x = viewPort.x + 4
1653-
self.controls.subTabAnchor.y = viewPort.y + 74
1650+
self.controls.subTabAnchor.y = viewPort.y + 96
1651+
1652+
-- Draw dividers between top-bar sections when a comparison is loaded
1653+
if #self.compareEntries > 0 then
1654+
SetDrawColor(0.25, 0.25, 0.25)
1655+
DrawImage(nil, viewPort.x + 4, viewPort.y + 32, viewPort.width - 8, 2)
1656+
DrawImage(nil, viewPort.x + 4, viewPort.y + 88, viewPort.width - 8, 2)
1657+
DrawImage(nil, viewPort.x + 4, viewPort.y + 122, viewPort.width - 8, 2)
1658+
end
16541659

16551660
self.controls.compareBuildLabel.x = function()
16561661
return 0
@@ -4118,9 +4123,9 @@ function CompareTabClass:DrawCalcsSkillHeader(vp, compareEntry, headerHeight, pr
41184123

41194124
-- Build name headers
41204125
SetDrawColor(1, 1, 1)
4121-
DrawString(leftX, y + 2, "LEFT", 16, "VAR BOLD",
4126+
DrawString(leftX, y + 2, "LEFT", 18, "VAR",
41224127
colorCodes.POSITIVE .. self:GetShortBuildName(self.primaryBuild.buildName))
4123-
DrawString(rightX, y + 2, "LEFT", 16, "VAR BOLD",
4128+
DrawString(rightX, y + 2, "LEFT", 18, "VAR",
41244129
colorCodes.WARNING .. (compareEntry.label or "Compare Build"))
41254130
y = y + rowH
41264131

0 commit comments

Comments
 (0)