Skip to content

Fix Cost efficiency math and add mods to breakdown#10004

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-ce
Jul 25, 2026
Merged

Fix Cost efficiency math and add mods to breakdown#10004
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-ce

Conversation

@vaisest

@vaisest vaisest commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #10003

Description of the problem being solved:

Math didn't line up with in-game where cost efficiency is added after other modifiers.

I also forgot to add the mods to the breakdown list, which I also fixed here.

Steps taken to verify a working solution:

  • Test added for flat cost
  • Old tests pass
  • Mods appear in calc tab

Link to a build that showcases this PR:

https://pobb.in/tr2e_xC5GInF

Before screenshot:

After screenshot:

@vaisest vaisest mentioned this pull request Jul 25, 2026
3 tasks
@LocalIdentity LocalIdentity changed the title Fix cost efficiency math and add mods to breakdown Fix Cost efficiency math and add mods to breakdown Jul 25, 2026
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jul 25, 2026
@LocalIdentity
LocalIdentity merged commit 592c240 into PathOfBuildingCommunity:dev Jul 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill Mana Cost Calculation

2 participants